Re: git: af1b62b7bc9a - main - Mk/bsd.options.desc.mk: Add ASLR

> On Dec 22, 2023, at 6:27 AM, Gleb Popov <arrowd@freebsd.org> wrote:
> 
> On Fri, Dec 22, 2023 at 4:24 AM Muhammad Moinur Rahman <bofh@freebsd.org> wrote:
>> 
>> diff --git a/Mk/bsd.options.desc.mk b/Mk/bsd.options.desc.mk
>> index df0787f752c6..d20740cc888a 100644
>> --- a/Mk/bsd.options.desc.mk
>> +++ b/Mk/bsd.options.desc.mk
>> @@ -30,6 +30,7 @@ APE_DESC?=            Monkey's Audio lossless format support
>> ARCHIVE_DESC?=         bzip2/zip/iso9660 archive support
>> ARMADILLO_DESC?=       TPS transform computation via Armadillo
>> ASIO_DESC?=            Asynchronous I/O support
>> +ASLR_DESC?=            Enable ASLR support
>> ASM_DESC?=             Use optimized assembly code
>> ASPELL_DESC?=          Spell checking support via GNU Aspell
>> ASSERT_DESC?=          Enable debug assertions
> 
> From Porter Handbook:
> 
>> When describing options, view it from the perspective of the user: "What functionality does it change?" and "Why would I want to enable this?" Do not just repeat the name. For example, describing the NLS option as "include NLS support" does not help the user, who can already see the option name but may not know what it means. Describing it as "Native Language Support via gettext utilities" is much more helpful.
> 
> Maybe the description should say "Enable Address Space Layout
> Randomization support" or "Enable Address Space Randomization" if the
> former is too long.

Thanks for the heads up. I will look into it on the next batch.

Kind regards,
Moin