Re: git: 61e4a788ecab - main - ports-mgmt/dialog4ports: mark as deprecated and broken on current
Date: Fri, 22 Dec 2023 08:08:35 UTC
22.12.2023 14:32, Baptiste Daroussin wrote: > On Fri, Dec 22, 2023 at 01:01:35PM +0700, Eugene Grosbein wrote: >> 21.12.2023 21:03, Baptiste Daroussin wrote: >> >>> First clearly none of those looks shitty to me! >>> >>> Anyway according to you which one do you fine neater and more convenient ? >>> >>> - https://bapt.nours.eu/1.png >>> - https://bapt.nours.eu/2.png >> >> Note that bsddialog-produced output depends on compiler due to a bug >> both in ports version of bsddialog utility and one in our base: >> it allocates "struct bsddialog_conf conf" on stack and fails to zero it, >> so it uses garbage for its contents including ascii_lines property >> that is supposed to be zero (disabled) but really can contain non-zero garbage. >> >> Eugene Grosbein >> > Have you provided a bug report upstream with this analysis? or even better a > patch ? While preparing a PR I found I was wrong and the library itself zeroes the struct before using it. Sorry for noise. Eugene Grosbein