From nobody Wed Dec 13 12:37:39 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sqw4P5Dftz53jk1 for ; Wed, 13 Dec 2023 12:37:57 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sqw4P3043z3D9v for ; Wed, 13 Dec 2023 12:37:57 +0000 (UTC) (envelope-from adamw@adamw.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-54c4f95e27fso6471576a12.1 for ; Wed, 13 Dec 2023 04:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20230601.gappssmtp.com; s=20230601; t=1702471075; x=1703075875; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cU9tgisIyZmxWx2FZBv5w1yYuZ9eYB6ZCebl4aPTUIo=; b=UZDYeZ9/qVUg8BE0RFNnLKCYdmDaUUQY6MSLU/bz86ziUXdQVUj6EKAy7r87g/QP4V 5C4kMhfxZbOb+0ShT+cXLAzuRta2K+FBG7sD7goIjTSftJ9uswLL8NJVybVCVt+lKzrI jnELHnWEJYiYPmxiYi4k5aXOKwI3NCE5C1swm8I7t2zpVsO+z2pGsctH5Su8r/4tYU/n ad+xRR77+pE/wR+i3O23IV2PKw7w+gGkqAde9t47KaDIXj8ZeAopqVGRvmk/8+7PMrly Bmx04fsAB3y/ObXYwh74ECN+juMPARKPnqvaeU9qgfj9xHF3J8bK1C4xlZg0o09gRvT+ 2YJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702471075; x=1703075875; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cU9tgisIyZmxWx2FZBv5w1yYuZ9eYB6ZCebl4aPTUIo=; b=MsvUnxI72T6UneCs4K3CXbrllHq1ZuFI/kblSLQSu5tSZroNcezQITz6zPGphnrK4a Mock5Wykqn2gv/ZjtW2DdWGc6BKQFWRCw3shgP6G73BBq7Zi3B9HUa6g8LWO1a1fBym1 hH0mNUTo+53+3G47GicBnf9b+GE/m4OUVauNd/p0LOeRiROgwTR+klsehU/JR5O6Vkcw HZloQOnz34XLBwqqQPLjZjYYJ0cwxb9zCECBetkgGFISqCImU23soTDyTtHNC/6nEjuY wwbkS4wLlk5cHRkdiotSEMytcPRPYEKAo0iz63zGqXXftP6hMtuLJ3OIoMfHV1oaujl5 IEAg== X-Gm-Message-State: AOJu0Ywvg7TBPMkCj0n33YM8hi1JyoEaJ5slajop2pcMTorFj3ptiIAR 26T5UBoDLNu+wdRV764Aw49F1lyZPQ3Vt4lf9vC2BQ== X-Google-Smtp-Source: AGHT+IH8nWujFa1YiqTLgIP5unuv9iOZFj3ZI2ACVLBtIyl0HyvjeE76tH1pL82HwjBuxLYiOd/AbXQHwptuTarhgCM= X-Received: by 2002:a50:9e2d:0:b0:54c:5e18:50e6 with SMTP id z42-20020a509e2d000000b0054c5e1850e6mr4566120ede.42.1702471075493; Wed, 13 Dec 2023 04:37:55 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202312050108.3B518qwD065426@gitrepo.freebsd.org> <653e5bc3811b06d371517936f02cf0c2@FreeBSD.org> <1e93ed1a910819a38a332a580b4746d0@FreeBSD.org> <526e9cf0-55cf-afac-b8b5-5005e63cc6ae@pfeifer.com> In-Reply-To: From: Adam Weinberger Date: Wed, 13 Dec 2023 07:37:39 -0500 Message-ID: Subject: Re: git: 8d096cbc7af5 - main - sysutils/lsof: add a build depends on bash for the timebeing. To: Mathieu Arnold Cc: Gerald Pfeifer , Larry Rosenman , Ashish SHUKLA , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b20ca5060c636fbf" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4Sqw4P3043z3D9v --000000000000b20ca5060c636fbf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 13, 2023 at 7:20=E2=80=AFAM Mathieu Arnold wr= ote: > On Wed, Dec 13, 2023 at 06:32:44AM -0500, Adam Weinberger wrote: > > On Wed, Dec 13, 2023 at 12:26=E2=80=AFAM Gerald Pfeifer > wrote: > > > > > On Mon, 4 Dec 2023, Larry Rosenman wrote: > > > >>> +BUILD_DEPENDS=3D /usr/local/bin/bash:shells/bash > > > >> s,/usr/local,${LOCALBASE}, > > > > I'm out of practice :( > > > > > > No worries, just note we have tools to support us. > > > > > > I gave this a try and got the following from portlint: > > > > > > % portlint -C > > > WARN: Makefile: possible use of absolute pathname > > > "/usr/local/bin/bash:...". > > > > > > > Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. This > > would work fine too (and is the more common invocation): > > BUILD_DEPENDS=3D bash:shells/bash > > They are semantically different. > > bash:shells/bash means I need a bash executable, like, for running shell > scripts. > > LOCAL/bin/bash:shells/bash means I need the LOCAL/bin/bash file, it may > not be for execution. It is more usually used for a header, I do not see > why one would need bash but not for running it. > > -- > Mathieu Arnold > That's a good point, and my message definitely glossed over that. foo:net/foo =3D=3D ${LOCALBASE}/bin/foo:net/foo (as long as foo is n= ot in base) ${LOCALBASE}/share/foo/foo.h:net/foo for non-executables # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --000000000000b20ca5060c636fbf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Wed, Dec 13, 2023 at 7:20=E2=80=AFA= M Mathieu Arnold <mat@freebsd.org= > wrote:
On W= ed, Dec 13, 2023 at 06:32:44AM -0500, Adam Weinberger wrote:
> On Wed, Dec 13, 2023 at 12:26=E2=80=AFAM Gerald Pfeifer <gerald@pfeifer.com> wr= ote:
>
> > On Mon, 4 Dec 2023, Larry Rosenman wrote:
> > >>> +BUILD_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0/usr/local/bin/bash:shells/bash
> > >> s,/usr/local,${LOCALBASE},
> > > I'm out of practice :(
> >
> > No worries, just note we have tools to support us.
> >
> > I gave this a try and got the following from portlint:
> >
> >=C2=A0 =C2=A0% portlint -C
> >=C2=A0 =C2=A0WARN: Makefile: possible use of absolute pathname
> > "/usr/local/bin/bash:...".
> >
>
> Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. Thi= s
> would work fine too (and is the more common invocation):
> BUILD_DEPENDS=3D=C2=A0 bash:shells/bash

They are semantically different.

bash:shells/bash means I need a bash executable, like, for running shell scripts.

LOCAL/bin/bash:shells/bash means I need the LOCAL/bin/bash file, it may
not be for execution. It is more usually used for a header, I do not see why one would need bash but not for running it.

--
Mathieu Arnold

That's a good point, and my message def= initely glossed over that.

=C2=A0 foo:net/foo=C2=A0 =3D=3D=C2=A0 ${LOCALBA= SE}/bin/foo:net/foo=C2=A0=C2=A0=C2=A0 (as long as foo is not in base)
=

=C2= =A0 ${LOCALBASE}/share/foo/foo.h:net/foo=C2=A0 for non-executables

# Adam


--
--000000000000b20ca5060c636fbf--