Re: git: 8d096cbc7af5 - main - sysutils/lsof: add a build depends on bash for the timebeing.

From: Mathieu Arnold <mat_at_freebsd.org>
Date: Wed, 13 Dec 2023 12:19:56 UTC
On Wed, Dec 13, 2023 at 06:32:44AM -0500, Adam Weinberger wrote:
> On Wed, Dec 13, 2023 at 12:26 AM Gerald Pfeifer <gerald@pfeifer.com> wrote:
> 
> > On Mon, 4 Dec 2023, Larry Rosenman wrote:
> > >>> +BUILD_DEPENDS=             /usr/local/bin/bash:shells/bash
> > >> s,/usr/local,${LOCALBASE},
> > > I'm out of practice :(
> >
> > No worries, just note we have tools to support us.
> >
> > I gave this a try and got the following from portlint:
> >
> >   % portlint -C
> >   WARN: Makefile: possible use of absolute pathname
> > "/usr/local/bin/bash:...".
> >
> 
> Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. This
> would work fine too (and is the more common invocation):
> BUILD_DEPENDS=  bash:shells/bash

They are semantically different.

bash:shells/bash means I need a bash executable, like, for running shell
scripts.

LOCAL/bin/bash:shells/bash means I need the LOCAL/bin/bash file, it may
not be for execution. It is more usually used for a header, I do not see
why one would need bash but not for running it.

-- 
Mathieu Arnold