From nobody Wed Dec 13 11:32:44 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SqtdW0pgZz53dgw for ; Wed, 13 Dec 2023 11:33:03 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SqtdV5LSdz4ZTy for ; Wed, 13 Dec 2023 11:33:02 +0000 (UTC) (envelope-from adamw@adamw.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-551c03ae050so1629444a12.2 for ; Wed, 13 Dec 2023 03:33:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20230601.gappssmtp.com; s=20230601; t=1702467180; x=1703071980; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sFpodXHWgGccOckoJRBcPMwowGxwdYHKFv3foD5RWEc=; b=yLmojn6Sc8KI2Tmn0Ave0tedytGQhnBMDWYh+WfuirdzyzE2WFwjg9h7MlYwstSgNf aZjg9W/vsBxOkoyjgtuOrsnqbVjo2EUn45oZ6JH1gJgt/+oyZ3aKzBJF1cSRbNMezCpl z+n2VmghmpU1scyVHxGemraygL1h0OU7Ty+5jLojiY9Fw2HEyxXEMZWxokBPFiaVYKY8 F/L30vjPMisIAtVhOlcDoGWnXyKQY/pPHIPDGX+SpqqfN1dKD7QpmFNLal31nIMyF06A Kb4ravKiuuiePbzPjWLBOOea4DNkooTwvAo87S1sRKYehGJLmM/hd0oNCcrl8AZ/D3Ca mAzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702467180; x=1703071980; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sFpodXHWgGccOckoJRBcPMwowGxwdYHKFv3foD5RWEc=; b=fm9Xo1UudOavFd7mN7AJH5/TPH6DMI8sGJd5pugisdcWmMD/Om3QTu/tILifWriKs7 ENmxEdDO+teSvjboftnHPJthSAwiZhyFWS2ii+JJQsxoHYbMBVwDAfbclULUOJBF9omn vglu1oUJQcrc3KUqWc1SvPMFJZmQiN2X6mytqYaufgR8RaP51O81QEfW3qoaK3C+YEV1 An1m56BRRdYXvO1RKx7T+dnfV9REbAt1unaJKTM/zYfSgDdquHQ+xdwLPq5OD9n6B7za AjnjDUEJPF7JPtAVXnHAm2JvkK5CGloVh+KzzJn5tRP1RiWWaprDXlFfm935E2z4j4K6 o0Yw== X-Gm-Message-State: AOJu0YySqe8wQ3YJGjqTl0zkHkj2vF9GZXyxdQ0oIaQbwrYwD/fqp4XQ AoKctTfKVcNHqm5ZBa9dhxwEuXYSgl3UUzZUwFXWDw== X-Google-Smtp-Source: AGHT+IFLS10tNhX+Z0W23MStI3ZfrMZ1UVYO6hk85Ev42D37ytSNOJWUb3wo3p8fFXYPQv8jXNmn2xjBbOt8KEn+AbM= X-Received: by 2002:a50:8e0c:0:b0:551:86d9:624e with SMTP id 12-20020a508e0c000000b0055186d9624emr1175011edw.63.1702467180458; Wed, 13 Dec 2023 03:33:00 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202312050108.3B518qwD065426@gitrepo.freebsd.org> <653e5bc3811b06d371517936f02cf0c2@FreeBSD.org> <1e93ed1a910819a38a332a580b4746d0@FreeBSD.org> <526e9cf0-55cf-afac-b8b5-5005e63cc6ae@pfeifer.com> In-Reply-To: <526e9cf0-55cf-afac-b8b5-5005e63cc6ae@pfeifer.com> From: Adam Weinberger Date: Wed, 13 Dec 2023 06:32:44 -0500 Message-ID: Subject: Re: git: 8d096cbc7af5 - main - sysutils/lsof: add a build depends on bash for the timebeing. To: Gerald Pfeifer Cc: Larry Rosenman , Ashish SHUKLA , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000888ef6060c628745" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SqtdV5LSdz4ZTy --000000000000888ef6060c628745 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 13, 2023 at 12:26=E2=80=AFAM Gerald Pfeifer wrote: > On Mon, 4 Dec 2023, Larry Rosenman wrote: > >>> +BUILD_DEPENDS=3D /usr/local/bin/bash:shells/bash > >> s,/usr/local,${LOCALBASE}, > > I'm out of practice :( > > No worries, just note we have tools to support us. > > I gave this a try and got the following from portlint: > > % portlint -C > WARN: Makefile: possible use of absolute pathname > "/usr/local/bin/bash:...". > Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. This would work fine too (and is the more common invocation): BUILD_DEPENDS=3D bash:shells/bash # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --000000000000888ef6060c628745 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Dec 13, 2023 at 12:26=E2=80=AFAM Gerald = Pfeifer <gerald@pfeifer.com>= ; wrote:
On Mon, 4 Dec 2023, Larry Rosenman wrote:
>>> +BUILD_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0/usr/local/bin/bash:shells/bash
>> s,/usr/local,${LOCALBASE},
> I'm out of practice :(

No worries, just note we have tools to support us.

I gave this a try and got the following from portlint:

=C2=A0 % portlint -C
=C2=A0 WARN: Makefile: possible use of absolute pathname "/usr/local/b= in/bash:...".

Also just FTR, BU= ILD/RUN_DEPENDS works without absolute pathnames. This would work fine too = (and is the more common invocation):
BUILD_DEPENDS=3D=C2=A0 bash:shells/bash<= /div>
# Adam


-- =
--000000000000888ef6060c628745--