Re: git: 1c35fdc48d6a - main - textproc/redland: Unbreak BDB option

From: Joseph Mingrone <jrm_at_FreeBSD.org>
Date: Tue, 12 Dec 2023 23:24:53 UTC
On Tue, 2023-12-12 at 20:48, "Jason E. Hale" <jhale@FreeBSD.org> wrote:

> The branch main has been updated by jhale:

> URL: https://cgit.FreeBSD.org/ports/commit/?id=1c35fdc48d6ae9ff7d417ad6b5409bdf79a67511

> commit 1c35fdc48d6ae9ff7d417ad6b5409bdf79a67511
> Author:     Jason E. Hale <jhale@FreeBSD.org>
> AuthorDate: 2023-12-12 20:10:37 +0000
> Commit:     Jason E. Hale <jhale@FreeBSD.org>
> CommitDate: 2023-12-12 20:41:25 +0000

>     textproc/redland: Unbreak BDB option

>     Before [1] we had former port devel/virtuoso explicitly disabled as a
>     pseudo-option, but this configure argument was lost in that commit. The
>     seemingly buggy configure script tries to use virtuoso despite its
>     non-existence.

>     rdf_storage_virtuoso.c:55:10: fatal error: 'sql.h' file not found

>     [1] https://cgit.freebsd.org/ports/commit/?id=134cdd54850031bfdc8202d27b1a69b2839d94bb

>     PR:             275700
>     Reported by:    <andy@neu.net>
> ---
>  textproc/redland/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/textproc/redland/Makefile b/textproc/redland/Makefile
> index 4a9ed73772dd..72449e33a5bc 100644
> --- a/textproc/redland/Makefile
> +++ b/textproc/redland/Makefile
> @@ -22,7 +22,8 @@ USE_LDCONFIG=	yes
>  USE_PERL5=	build
>  SHEBANG_FILES=	scripts/touch-mtime.pl
>  GNU_CONFIGURE=	yes
> -CONFIGURE_ARGS=	--with-threestore=no
> +CONFIGURE_ARGS=	--with-threestore=no \
> +		--with-virtuoso=no

>  INSTALL_TARGET=	install-strip
>  TEST_TARGET=	check

It's certainly better to explicitly set this configure option, but I'm
curious why the submitter was seeing the failure.  I tested all option
combinations in different poudriere jails.  I would have guessed he was
building on a live system with virtuoso installed, but
databases/virtuoso was removed.

In any case, thanks for fixing.

Joe