Re: git: 8848573087ff - 2023Q4 - www/nginx: fix build with a third-party passenger module

From: Mathieu Arnold <mat_at_freebsd.org>
Date: Sun, 03 Dec 2023 11:07:37 UTC
On Sun, Dec 03, 2023 at 11:24:54AM +0100, Jochen Neumeister wrote:
> 
> Am 03.12.23 um 11:21 schrieb Mathieu Arnold:
> > On Sun, Dec 03, 2023 at 11:01:26AM +0100, Jochen Neumeister wrote:
> > > Is it normal that you just do something like that here without consulting
> > > anyone? What do we have rules for here?
> > Well, who would meta@ need to consult about this? It is a simple fix,
> > any committer can commit those, and also any committer can merge it into
> > the current quarterly.  Here is the rule, taken from
> > https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-maintainer
> > that explicitly says that:
> > 
> > 	Maintainers have the primary responsibility for their ports, but
> > 	not exclusive ownership. Ports exist for the benefit of the
> > 	community and, in reality, belong to the community. What this
> > 	means is that people other than the maintainer can make changes
> > 	to a port.
> 
> 
> So you're saying it's okay if someone else posts this in the quaterly brach
> a few minutes after it's commit? You don't care that the maintainer is still
> working on it? Thank you for this explanation!

What I mean is that anyone can do this, yes. It does not mean that you,
as the maintainer, cannot commit a better fix if you have one, there is
no indication in the PR that you were working on it.
Also, there is no need to be mean, sarcastic or abrasive about all this.

-- 
Mathieu Arnold