Re: git: aa8f9390170e - main - www/nginx-full: fix package build

Moin moin

Yes, there are rules about timeouts, and the 'maintainer timeout' was
wrong here.
However, this change is covered quite nicely by the 'just fix
it'-portmgr blanket.

mfg Tobias with hat portmgr

On Sun, 3 Dec 2023 at 10:23, Jochen Neumeister <joneum@freebsd.org> wrote:
>
>
> Am 03.12.23 um 10:03 schrieb Koichiro Iwao:
> > The branch main has been updated by meta:
> >
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=aa8f9390170e1e4f8470ccd7f03e54ab0ba77e61
> >
> > commit aa8f9390170e1e4f8470ccd7f03e54ab0ba77e61
> > Author:     Koichiro Iwao <meta@FreeBSD.org>
> > AuthorDate: 2023-11-22 14:26:25 +0000
> > Commit:     Koichiro Iwao <meta@FreeBSD.org>
> > CommitDate: 2023-12-03 09:03:15 +0000
> >
> >      www/nginx-full: fix package build
> >
> >      nginx-full requires either to enable GSSAPI_MIT or GSSAPI_HEIMDAL but
> >      none is enabled. As a result, fails to build bibary package on package
> >      build cluster.
> >
> >      PR:             275262
> >      Approved by:    maintainer timeout
>
>
> I don't see a "maintainer timeout" here. The PR was opened on
> 22.11.2023. So it has not yet exceeded the 2 weeks. That would be
> 06.12.2023 at the earliest.
> You can find the policies here:
> https://www.freebsd.org/portmgr/policies_contributors/
>
> Please refrain from publishing something as a "maintainer timeout" that
> is not correct, thank you.
>
> Cheers
> Jochen
>
>
> > ---
> >   www/nginx-full/Makefile | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/www/nginx-full/Makefile b/www/nginx-full/Makefile
> > index 1aa50bba4d76..439f80968324 100644
> > --- a/www/nginx-full/Makefile
> > +++ b/www/nginx-full/Makefile
> > @@ -35,4 +35,10 @@ OPTIONS_DEFAULT=DSO DEBUG DEBUGLOG FILE_AIO GOOGLE_PERFTOOLS \
> >               RTMP SET_MISC SFLOW SHIBBOLETH SLOWFS_CACHE SMALL_LIGHT \
> >               SRCACHE STATSD VOD VTS UDPLOG X11 XSS WEBSOCKIFY
> >
> > +.if defined(PACKAGE_BUILDING) || defined(BATCH)
> > +# Either GSSAPI_MIT or GSSAPI_HEIMDAL must be enabled to build binary package.
> > +# There's no chance to choose GSSAPI_RADIO via dialog while package building.
> > +OPTIONS_DEFAULT+=    GSSAPI_MIT
> > +.endif
> > +
> >   .include "${MASTERDIR}/Makefile"