From nobody Sat Apr 15 07:40:29 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pz4yt5RxZz44pHH; Sat, 15 Apr 2023 07:42:14 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pz4ys6htfz3vrY; Sat, 15 Apr 2023 07:42:13 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681544533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XGEeDX7Py5mxyDoBraEVmXPsGmVxidyPPzpcQ+9B/eg=; b=yjMR6wqxGPlcdsfXnNFOVqX8bqU7i+zJg8rjrXQ14KMnLzfIOnd8K3tUcfmBxhfQXiSSWy n/dhY9sw51vWErBsjnmEneNxt0KDANR+5ASVJKqaNdLkKFDJpMlzWGGdlMzC45bmQJNGtH Q19nHuyzmQ8Cxha1nGw1vTg3+frUUTQfpkY610kvldtW8Rn8d5BlylkZwQmFTjKI0Sspqa k9i+t6jR1HjVtWfd1L8B7DaUeliLi0Vn41JqU2kBdhHlqcC1Z2d8L1DgsSQghMYwGn2z+J 2kqIoheSu9k9ZZOgtdOx/U9I1fi6zZLWD+7iZyi2tE8CPdDxboQcgk30NNWLOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681544533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XGEeDX7Py5mxyDoBraEVmXPsGmVxidyPPzpcQ+9B/eg=; b=Mc1Mr1FGqtGFrfoanTvFGcU08kqbMCoGkDMcjslN0HhE7E2pxhygyU2JUWEnxCO7eJRYHF 6I4d64zO5fCFMNmvJSzT8/1p++gzN057+dX6owtfeI4x6VrxW1L41BVIvY0WXpiljjUhwp Zrb4QRuhsbX/drsR17W6+ISdTPnDCZZ01BGzJzEqeqtJu3HOJsc0u6Pg4/Uts/WcgSVaB/ wJ3rblw6Ost3lu1JcQ6D8mwpRFXdFcphrrC8JvD3HCOZzXqt2hgQcwGiQSfwcgxwIBrGKD 0KtlDwJj3aZVSiOVP9NgzmmoyVN4OcCzbZfuk7ujZQY4mZKTHHMqwvgHtqnuQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681544533; a=rsa-sha256; cv=none; b=AQB+NHEWOL+m6ytgaWuRK4vlLhbV92N79OPaXU+wMBtQPTzgcz2oOTTOQpMR78zuXBaYRp NrJbVEGcrJpnQ2B8DAV2Ebrl2728xKm/Yp5y9hNWh2rMvMqKnAwMqzhBP020dQ9M55nVaS UglTfP50Kj59+Ea8iqhklaSaLx3AySlpiOJ7Ibp76J0hMGrya66lqXnxQJDP2MfcCbuvio 5SwCiY8IF7hCmrwM36Gr73urOOUYHJLK4sOCOO2nYmrTj9rU6rI64FcRn17vETXLs9ZFUb ZqxsmJFe9xhggoLD+a8fDqzmia20hHdi5/bVDhrl0/t0cHcV7cEPJUQ+VSlGqA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id C2E9C176CD; Sat, 15 Apr 2023 07:40:29 +0000 (UTC) Date: Sat, 15 Apr 2023 07:40:29 +0000 From: Alexey Dokuchaev To: Eugene Grosbein Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 3f3975ef8c26 - main - java/openjdk11: add new CUPS port option Message-ID: References: <202304150444.33F4ijSK040858@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202304150444.33F4ijSK040858@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Sat, Apr 15, 2023 at 04:44:45AM +0000, Eugene Grosbein wrote: > commit 3f3975ef8c2692cc0aedf26becd3ee6d2754fb81 > > java/openjdk11: add new CUPS port option > > This change introduces new CUPS port option to java/openjdk11 > that defaults to ON to preserve current behaviour. > With CUPS option turned OFF it skips build dependency on full cups: > instead, it downloads and extracts its distfile and > builds --with-cups-include pointing to extracted cups distfile. > ... > +CUPS_DISTFILES_OFF= OpenPrinting-cups-v${CUPS_INC_VER}_GH0.tar.gz:cups > + > +.if !${PORT_OPTIONS:MCUPS} > +MASTER_SITES+= https://codeload.github.com/OpenPrinting/cups/tar.gz/v${CUPS_INC_VER}?dummy=/:cups > +.endif You should've probably depended on ${NONEXISTENT}:print/cups:patch, this way you avoid having to keep two verions in sync and can benefit from any patches that CUPS might require on FreeBSD, something like this: BUILD_DEPENDS= ${NONEXISTENT}:print/cups:patch _CUPS_WRKSRC= ${MAKE} -C ${PORTSDIR}/print/cups -V WRKSRC CUPS_CONFIGURE_OFF= --with-cups-include=${_CUPS_WRKSRC:sh}/cups/cups.h ./danfe