Re: git: e933541b2131 - main - devel/samurai: Fix if LOCALBASE is not /usr/local

On Wed, Apr 5, 2023 at 9:58 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:

> On Wed, Apr 05, 2023 at 05:43:38AM +0000, Fernando Apestegu??a wrote:
> > commit e933541b2131d644ce243630544bcf210fb4be84
> >
> >   devel/samurai: Fix if LOCALBASE is not /usr/local
> >
> >   PR:             270590
> >   Reported by:    eric@camachat.org
> > ...
> >  PORTNAME=    samurai
> >  DISTVERSION= 1.2-16
> > +PORTREVISION=        1
>
> Needless bump for build-time change?
>
> > -@@ -3,7 +3,7 @@
> > - PREFIX=/usr/local
> > +@@ -1,10 +1,10 @@
> > + .POSIX:
> > + .PHONY: all install clean
> > +
> > +-PREFIX=/usr/local
> > ++PREFIX=${LOCALBASE}
>
> This doesn't look right, PREFIX is semantically different from LOCALBASE
> even
> though they typically point to the same path (PREFIX is where your
> generated
> stuff goes, LOCALBASE is where you get precursors).  If this program abuses
> the PREFIX variable and it is actually meant to be LOCALBASE, it's better
> to
> fix the Makefile or at least accompany such change with due comment.
>
>
Should be correct now.

Thanks!


> ./danfe
>