Re: git: aa1913df7f3f - main - devel/py-responses: switch to USES=pytest
Date: Mon, 21 Nov 2022 13:53:46 UTC
* Po-Chuan Hsieh (sunpoet@freebsd.org) wrote:
> On Mon, Nov 7, 2022 at 8:28 PM Dmitry Marakasov <amdmi3@freebsd.org> wrote:
>
> The branch main has been updated by amdmi3:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=
> aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4
>
> commit aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4
> Author: Dmitry Marakasov <amdmi3@FreeBSD.org>
> AuthorDate: 2022-11-07 12:14:58 +0000
> Commit: Dmitry Marakasov <amdmi3@FreeBSD.org>
> CommitDate: 2022-11-07 12:27:46 +0000
>
> devel/py-responses: switch to USES=pytest
>
>
> Please stop doing this.
> It should be USE_PYTHON=pytest, not USES=pytest.
> Furthermore, all existing USES=pytest should be changed to USE_PYTHON=pytest.
Sorry, but you can't just tell me to stop using the framework I've
introduced, without at least notifying me beforehand of that there's
now a duplicate framework which is now preferred.
In fact unfortunately I will not stop unless all the ports are
converted to USE_PYTHON=pytest and USES=pytest removed (which you
should've done in the first place to save everybodys time and avoid
ambiguity) as I have a lot of pending commits with migration to
USES=pytest I don't feel like redoing unless I have to.
Thank you for your work anyway, this looks more flexible whan
USES=pytest.
> Approved by: portmgr blanket
> ---
> devel/py-responses/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/devel/py-responses/Makefile b/devel/py-responses/Makefile
> index 8469076cffc4..53492b036954 100644
> --- a/devel/py-responses/Makefile
> +++ b/devel/py-responses/Makefile
> @@ -18,14 +18,13 @@ RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}mypy>=
> 0:devel/py-mypy@${PY_FLAVOR} \
> TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}coverage>=6.0.0:devel/py-coverage@$
> {PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}flake8>=0:devel/py-flake8@$
> {PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}mypy>=0:devel/py-mypy@${PY_FLAVOR} \
> - ${PYTHON_PKGNAMEPREFIX}pytest>=7.0.0:devel/py-pytest@$
> {PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}pytest-asyncio>=0:devel/
> py-pytest-asyncio@${PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}pytest-cov>=0:devel/py-pytest-cov@$
> {PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}pytest-localserver>=0:devel/
> py-pytest-localserver@${PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}types-mock>=0:devel/py-types-mock@$
> {PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}types-requests>=0:devel/
> py-types-requests@${PY_FLAVOR}
>
> -USES= python:3.7+
> +USES= python:3.7+ pytest
> USE_PYTHON= autoplist concurrent distutils
>
> NO_ARCH= yes
>
--
Dmitry Marakasov .
amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/