Re: git: dfae67d10c3f - main - bsd.port.mk: Use zstandard as default compression for FreeBSD 14+

On 5/5/2022 5:06 PM, Bryan Drewery wrote:
> On 5/3/2022 5:12 AM, Baptiste Daroussin wrote:
>> The branch main has been updated by bapt:
>>
>> URL: 
>> https://cgit.FreeBSD.org/ports/commit/?id=dfae67d10c3f2b6dbde7d6e3280455cd87f9f15c 
>>
>>
>> commit dfae67d10c3f2b6dbde7d6e3280455cd87f9f15c
>> Author:     Baptiste Daroussin <bapt@FreeBSD.org>
>> AuthorDate: 2022-04-29 14:03:13 +0000
>> Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
>> CommitDate: 2022-05-03 12:04:26 +0000
>>
>>      bsd.port.mk: Use zstandard as default compression for FreeBSD 14+
>>      The packages are switched from XZ to ZSTD compression, the 
>> compression level
>>      is set at the maximum possible because it creates packages which 
>> are closed
>>      in size between XZ and ZSTD, the compression time is close as well,
>>      but decompression time is way bigger.
>>      Exp-run:        antoine
>>      Differential revision:  https://reviews.freebsd.org/D35095
>> ---
>>   Mk/bsd.port.mk | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
> 
> Please can the symlink generation for this be disabled? It causes 
> problems for Poudriere. Everything was stable with the .txz transition 
> and now we have .tzst symlinks being created that Poudriere does not 
> expect. It does not make sense to have transition symlinks for a new 
> format.

Last time we discussed this I believe you thought only ports-mgmt/pkg 
itself had a symlink, but no, every package built gets the symlink.

> 
>> diff --git a/Mk/bsd.port.mk b/Mk/bsd.port.mk
>> index be720a035d87..c2760881ac04 100644
>> --- a/Mk/bsd.port.mk
>> +++ b/Mk/bsd.port.mk
>> @@ -2214,11 +2214,11 @@ PKG_SUFX=    .pkg
>>   .    if defined(PKG_NOCOMPRESS)
>>   PKG_COMPRESSION_FORMAT?=    tar
>>   .    else
>> -#.if ${OSVERSION} > 1400000
>> -#PKG_COMPRESSION_FORMAT?=    tzst
>> -#.else
>> +.if ${OSVERSION} > 1400000
>> +PKG_COMPRESSION_FORMAT?=    tzst
>> +.else
>>   PKG_COMPRESSION_FORMAT?=    txz
>> -#.endif
>> +.endif
>>   .    endif
>>   # where pkg(8) stores its data
> 
> 


-- 
Bryan Drewery