Re: git: b71f7e3faa71 - main - graphics/gdal: switch to C++17 for upcoming poppler

From: Po-Chuan Hsieh <sunpoet_at_freebsd.org>
Date: Tue, 29 Mar 2022 13:38:38 UTC 
On Tue, Mar 29, 2022 at 8:45 PM Adriaan de Groot <adridg@freebsd.org> wrote:

> The branch main has been updated by adridg:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=b71f7e3faa7181387717df55cfd009db723b3d71
>
> commit b71f7e3faa7181387717df55cfd009db723b3d71
> Author:     Adriaan de Groot <adridg@FreeBSD.org>
> AuthorDate: 2022-03-28 19:20:06 +0000
> Commit:     Adriaan de Groot <adridg@FreeBSD.org>
> CommitDate: 2022-03-29 12:44:53 +0000
>
>     graphics/gdal: switch to C++17 for upcoming poppler
>
>     This is a fix-it-before-it-breaks for a poppler update that requires
>     consumers (like gdal) to compile in C++17 mode.
>
>     PR:             260956
> ---
>  graphics/gdal/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/graphics/gdal/Makefile b/graphics/gdal/Makefile
> index 5cd9500a265b..9d874f096276 100644
> --- a/graphics/gdal/Makefile
> +++ b/graphics/gdal/Makefile
> @@ -2,7 +2,7 @@
>
>  PORTNAME=      gdal
>  PORTVERSION=   3.4.1
> -PORTREVISION=  8
> +PORTREVISION=  9
>  CATEGORIES=    graphics geography
>  MASTER_SITES=  https://download.osgeo.org/gdal/${PORTVERSION}/ \
>                 LOCAL/sunpoet
> @@ -42,12 +42,12 @@ PCRE2_DESC= Regular expression support for SQLite
>  RASTERLITE2_DESC=      RasterLite2 support
>  TILEDB_DESC=   TileDB support
>
> -USES=          compiler:c++14-lang cpe gmake iconv jpeg localbase
> pkgconfig ssl tar:xz
> +USES=          compiler:c++17-lang cpe gmake iconv jpeg localbase
> pkgconfig ssl tar:xz
>
>  CFLAGS+=       -fPIC
>  CONFIGURE_ARGS=        --datadir=${PREFIX}/share \
>                 --enable-static=yes \
> -               --with-cpp14 \
> +               --with-cpp17 \
>

Please revert this. There is no such argument (--with-cpp17).
Thanks.


>                 --with-crypto=yes \
>                 --with-geotiff=yes \
>                 --with-gif=yes \
> @@ -69,7 +69,7 @@ CONFIGURE_ARGS=       --datadir=${PREFIX}/share \
>  GNU_CONFIGURE= yes
>  LDFLAGS+=      ${ICONV_LIB}
>  MAKEFILE=      GNUmakefile
> -USE_CXXSTD=    c++14
> +USE_CXXSTD=    c++17
>  USE_LDCONFIG=  yes
>
>  PLIST_SUB=     PORTVERSION=${PORTVERSION}
>
>