From nobody Sun Apr 24 19:13:51 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C4FFB1A8BF74; Sun, 24 Apr 2022 19:13:51 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kmd9C5J4vz4hwZ; Sun, 24 Apr 2022 19:13:51 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650827631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yJboRBAczR3ZFs1YCOOrrQjRHj4q+9QLyVKLahIR4Js=; b=ZmFYAq96DvlxguLnYNxukMht7QHD2Gu2eU1G2yhuV/d9rN4FPV4GMD3iP6BpR8m7UO+TLo W16maGpEAnkFtxNolf+Hr24LtzYmunkcFFK1zRaTXrijTGrxk/pLLENx6063aP8GBDWAqX acB/bHvHXIrCd0XMwZ44BzGLt6aMB+adddDmVIOgDYiey8/XRFaN8bjkJnFbA/n/Leen4h BCY62XzOChMfPrSRm26xd0gNsP4EYqzXw1ajp37d37B6k64rZ8qn2WJsjTQIImZjcf2p9l x97LiyTdKu7FoV81pbObmW8nfX7OE08CLb4Izty9KiZM/gZYTfYt8CWLz/k/mQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 87AC41B3F1; Sun, 24 Apr 2022 19:13:51 +0000 (UTC) Date: Sun, 24 Apr 2022 19:13:51 +0000 From: Alexey Dokuchaev To: Adriaan de Groot Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, "Tobias C. Berner" Subject: Re: git: aa2539679084 - main - framework: cleanup conditional-indentations in Mk/ Message-ID: References: <202204241007.23OA70ca039751@gitrepo.freebsd.org> <7805992.iDzAj6rjnq@beastie.bionicmutton.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7805992.iDzAj6rjnq@beastie.bionicmutton.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650827631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yJboRBAczR3ZFs1YCOOrrQjRHj4q+9QLyVKLahIR4Js=; b=IT4SR4eg6ZB+ZayffVEllb2bEe9Yxt/5WhebAIhstjyK9RjJmi/zqL4wE3szzD+MyYOCq1 9bHT/ju7j2TYjTY+vkoydHNWrgbgVZfLQaUvbkpgs7cKABaEpi5GOAexeoVJB7X5KSONtS 4Ahwrq+8vm7NNz1UhVmYCEyxtUZ1wESLvBfn0qqWgUhw4/6oHDgCNwPqgi0Ox66jKt2Ker keyLIQkSFG8oirQn5r6l4SdXEjLAoBWWgGZqMAwlKgby2Owdc7whkLYzs98dOsapNbg02Z CVewitdaRO/2KEuDHVJP/UehjkRX0/MdV2sXekEFIA8RFwjSNQgBXk+PmYy8cQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650827631; a=rsa-sha256; cv=none; b=wUTBuPvDs4PJkS5Gl0xlrI2vqUuYw5BxDz69Xn3MQIFtS0EANVGBFkKVgZpwSDh75t0VaH uzRbHkBUJmd1smP+ogQP8OCYVulx8ub3EBeG3vZMU1V6zbmlz7BBjMX3vzCN/Bb1qEVUqp E9Zcm1ukp+qFcr7G1cz6TnqFqEZgbotRFquKE7Z+flcFa6rSoy8CkI+eNmOs2veSVIC5tl 2fzpB3mmNNmSxZVpPjtyvXLkxA9Vds3OboNj0DqvuDA5nGkGs3wKrMxmXUtTN2WdNDC503 SLD/2gqteSLTgv7ZD33QOuQ2u94WTAs/TW2x4Qk/8aIkJBEyZ3WHKuyPbuEgKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Sun, Apr 24, 2022 at 07:51:33PM +0200, Adriaan de Groot wrote: > On Sunday, 24 April 2022 12:07:00 CEST Tobias C. Berner wrote: > > The branch main has been updated by tcberner: > > > > commit aa2539679084872cd84112e9df6bfee571570623 > > > > framework: cleanup conditional-indentations in Mk/ > > > > These white space changes contribute greatly to the readability of those > > files. As we have a version control system, finding out the reasons for the > > changes prior to these white space changes is still easily possible > > This is a nice moment to point at "git blame" -- which will tell you when a > line was last changed, and by whom. Naive use of "git blame" will now point a > lot of lines at tcberner@, even though it was just whitespace. You can tell > "git blame" to ignore certain revisions, and so discover the original authors > before the white-space changes. Or one can just ask for `git blame' just before that revision: $ git blame aa25396790848^ Mk/bsd.sites.mk # (notice the caret) > Actually, "blame" is kind of an unfriendly name. We should be cheering for > the people who create the software we use daily! Sadly, most of the times I have to issue `git blame' is not to cheer about a particular change, but, really, blame. FWIW, Subversion has `svn praise' which is an alias for `svn blame'. ./danfe