From nobody Sat Apr 16 22:56:29 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3417511D62B1; Sat, 16 Apr 2022 22:56:32 +0000 (UTC) (envelope-from ler@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KgpTr0lSDz4Qnw; Sat, 16 Apr 2022 22:56:32 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650149792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NWJQm1Urof4nij1MTCBnv9pScVwr9AXdyTnrnaHDccw=; b=DN7CAIxietuWfZGK8lzQ61cY32QpQNEAscm15jVA0qR6hvBNA2EHNZ8cJNw9LHADNVgmo/ wNc4lY5TQzS7+TvS9qIpopcZ2XUSYXnQiEuHrU4rxVs6LE5KS+8AelvjezvC3XlFyMD1Xb Al6yyJxteNRWZSfG3uEg5kWO/+akaeu94FrQpetbIaqsl5a7epEu1ZUwSVLDRG8H0L9g1k PYTHmwwfPAW8iHQQoHtiXAQWanz81Rn7N1z1BLI8NqxlIPMsA0GF8mVcrNx1WVrYZHDjmV Q2J29GteuNzpA2+XCseffZmpFfpWtE3lpcotP1sp5G28FQQKErGdB9FlGk+Ung== Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [IPv6:2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.lerctr.org", Issuer "R3" (verified OK)) (Authenticated sender: ler/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id ED1207DB6; Sat, 16 Apr 2022 22:56:31 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NWJQm1Urof4nij1MTCBnv9pScVwr9AXdyTnrnaHDccw=; b=uIxPWSIVj/SlA9QwVrMoDxxvMu 08NeBthkBe5lpIVLWevypRa7FNI26Rf0heZhtBPQBgObv2wEYQJL0RK75Q0hnNwb53frJncPLwSHM 5FRjGbM0m4FdS7Ti6X0/mokA0OU/Mt9SK2ymdTvACCDqzh2orGZ0uoAbT32fSRPbUUL0c8MjDR9z2 nmOhV3EtjJKLticv248SossdzE13puVrzk8DL+HFU9PCm5T3eqar4aghy6Wws4V/XAFIoOvbzoq/a YYYBvHU0wzzqEIZhp+6fJoCbdPU1pxg64g69nVtEzH6aZ4ZOPHrZ05G6QiLWoUg3XbDViHsplO6TK vEcSbtMg==; Authentication-Results: thebighonker.lerctr.org; iprev=pass (thebighonker.lerctr.org) smtp.remote-ip=2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4; auth=pass (LOGIN) smtp.auth=ler@lerctr.org; spf=softfail smtp.mailfrom=FreeBSD.org; dmarc=skipped header.from=FreeBSD.org; arc=none Received-SPF: softfail (thebighonker.lerctr.org: transitioning domain of FreeBSD.org does not designate 2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4 as permitted sender) client-ip=2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4; envelope-from=ler@FreeBSD.org; helo=webmail.lerctr.org; Received: from thebighonker.lerctr.org ([2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4]:20807 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95 (FreeBSD)) (envelope-from ) id 1nfrLC-000LKU-3y; Sat, 16 Apr 2022 17:56:30 -0500 Received: from 2600:1700:210:b18f:9a5:6d9f:e9f2:92cf by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Sat, 16 Apr 2022 17:56:29 -0500 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Date: Sat, 16 Apr 2022 17:56:29 -0500 From: Larry Rosenman To: Mathieu Arnold Cc: Neel Chauhan , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 0dd69d0adfd2 - main - mail/dovecot: Add FLAVORs for CDB, LDAP, MYSQL, PGSQL, and SQLITE3 In-Reply-To: <20220416225515.qppw6vzsebek6ns3@aching.in.mat.cc> References: <202204152248.23FMmKfV041481@gitrepo.freebsd.org> <20220416225515.qppw6vzsebek6ns3@aching.in.mat.cc> Message-ID: <0d7878ec04505a9f478f02746523efc1@FreeBSD.org> X-Sender: ler@FreeBSD.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650149792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NWJQm1Urof4nij1MTCBnv9pScVwr9AXdyTnrnaHDccw=; b=VIgYf0I+4EDcGoGtgxTLapl5t+CTzsW/JV7mQDhB5kYad0FmGmlATBjVy5dz2s+JAYF2hg +pQy2huXAhIiCUsPER5xViRJkjTP2+efFP1DxVfbz+8P8Yl7Gghx9PZJvde6I0e2u9K+yi 2tEok4A+2HIwvZsd/Nf+N9u8JU3Im6hwoAf+CHXrNGbqUm3YYeifxqYlKimGvLlXdp19PP cKH/ZHy3P3Ko29Tx8sjCP9vduBX4i9tIgIHGECKlLs4Eoaxuc43+V/BFC7bpldkX/Z6+5d SC+V9TVIRpbmKz+UjUYRb/zq9GzX4fh1xDZNKzsIgFZ9vdxoHOF4N49+t+x92Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650149792; a=rsa-sha256; cv=none; b=h+UShxl9h4if8YgQtUhEvAgUSKPB9AJz6c7vmE5iS5+HOcD3Tx1LV0NXAeu2mlwbfelu6Q L7rncUv2+4uSMYDwUe1Sfu12gPCDwV5OlC5VikD0U7Rm0QOVRF0bWxOb/UxCNRoS7D1AgD CKMyrEivvRMRT6CJG19/ATrZyv45w52uNmTJ0uDYTPMdekEvXjMWbC+5H5yAM6evEp9iM+ kBIIIt0ezjBrefIf5zb5zE8v3Ps73jy6syxFUWm9zu6zr+gRP3Etz9vh+wqPeH0AYGHJxw ofRW21i4+TojbmN+JLKT99PM+OUHptu82N6N3kiYYgefleP3yi3Pu96h8/fo2A== ARC-Authentication-Results: i=1; thebighonker.lerctr.org; iprev=pass (thebighonker.lerctr.org) smtp.remote-ip=2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4; auth=pass (LOGIN) smtp.auth=ler@lerctr.org; spf=softfail smtp.mailfrom=FreeBSD.org; dmarc=skipped header.from=FreeBSD.org; arc=none X-ThisMailContainsUnwantedMimeParts: N On 04/16/2022 5:55 pm, Mathieu Arnold wrote: > On Fri, Apr 15, 2022 at 10:48:20PM +0000, Neel Chauhan wrote: >> The branch main has been updated by nc: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=0dd69d0adfd2ef48dc949bb2325c2c534117fc29 >> >> commit 0dd69d0adfd2ef48dc949bb2325c2c534117fc29 >> Author: Neel Chauhan >> AuthorDate: 2022-04-15 22:47:24 +0000 >> Commit: Neel Chauhan >> CommitDate: 2022-04-15 22:48:18 +0000 >> >> mail/dovecot: Add FLAVORs for CDB, LDAP, MYSQL, PGSQL, and SQLITE3 > > You are probably abusing flavors to get subpackages, please revert. I already reverted it :) > >> PR: 254164 >> Approved by: maintainer timeout (>1 year) >> --- >> mail/dovecot/Makefile | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/mail/dovecot/Makefile b/mail/dovecot/Makefile >> index 0379f598643f..4b96bf4c4506 100644 >> --- a/mail/dovecot/Makefile >> +++ b/mail/dovecot/Makefile >> @@ -23,6 +23,14 @@ LIB_DEPENDS= libzstd.so:archivers/zstd >> USES= cpe iconv libtool pkgconfig ssl >> USE_RC_SUBR= dovecot >> >> +FLAVORS= default cdb ldap mysql pgsql sqlite3 >> +FLAVOR?= ${FLAVORS:[1]} >> +cdb_PKGNAMESUFFIX= -cdb >> +ldap_PKGNAMESUFFIX= -ldap >> +mysql_PKGNAMESUFFIX= -mysql >> +pgsql_PKGNAMESUFFIX= -pgsql >> +sqlite3_PKGNAMESUFFIX= -sqlite3 >> + >> GNU_CONFIGURE= yes >> CONFIGURE_ARGS= --localstatedir=/var \ >> --with-docs \ >> @@ -48,6 +56,22 @@ OPTIONS_GROUP_FTS= ICU LUCENE SOLR TEXTCAT >> OPTIONS_SINGLE= GSSAPI >> OPTIONS_SINGLE_GSSAPI= GSSAPI_NONE GSSAPI_BASE GSSAPI_HEIMDAL >> GSSAPI_MIT >> >> +.if ${FLAVOR} == cdb >> +OPTIONS_DEFAULT+= CDB >> +.endif >> +.if ${FLAVOR} == ldap >> +OPTIONS_DEFAULT+= LDAP >> +.endif >> +.if ${FLAVOR} == mysql >> +OPTIONS_DEFAULT+= MYSQL >> +.endif >> +.if ${FLAVOR} == pgsql >> +OPTIONS_DEFAULT+= PGSQL >> +.endif >> +.if ${FLAVOR} == sqlite3 >> +OPTIONS_DEFAULT+= SQLITE3 >> +.endif >> + >> DB_DESC= Database support >> CDB_DESC= CDB database support >> >> -- Larry Rosenman http://people.freebsd.org/~ler Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106