Re: git: 329f5c880471 - main - ports-mgmt/reprise: unbreak bulk -a

From: Dmitry Marakasov <amdmi3_at_amdmi3.ru>
Date: Wed, 13 Apr 2022 13:14:02 UTC
* Antoine Brodin (antoine@FreeBSD.org) wrote:

Please revert this.

You're removing _correct_ python version limitation and preventing
port users from building the port. Also the IGNORE is incorrect for
it will never support outdated versions of python.

If it breaks poudriere, it should be fixed in poudriere, or the
port should be marked in a way so poudriere does not build it, not
affecting port users.

> The branch main has been updated by antoine:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=329f5c8804717f22745217a686ec4c115a5a40d4
> 
> commit 329f5c8804717f22745217a686ec4c115a5a40d4
> Author:     Antoine Brodin <antoine@FreeBSD.org>
> AuthorDate: 2022-04-12 07:48:55 +0000
> Commit:     Antoine Brodin <antoine@FreeBSD.org>
> CommitDate: 2022-04-12 07:48:55 +0000
> 
>     ports-mgmt/reprise: unbreak bulk -a
> ---
>  ports-mgmt/reprise/Makefile | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/ports-mgmt/reprise/Makefile b/ports-mgmt/reprise/Makefile
> index 9036d653355c..b2e81455ecb0 100644
> --- a/ports-mgmt/reprise/Makefile
> +++ b/ports-mgmt/reprise/Makefile
> @@ -12,7 +12,7 @@ RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}jsonslicer>=0:textproc/py-jsonslicer@${PY_FL
>  TEST_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pytest>=0:devel/py-pytest@${PY_FLAVOR} \
>  		${PYTHON_PKGNAMEPREFIX}pytest-asyncio>=0:devel/py-pytest-asyncio@${PY_FLAVOR}
>  
> -USES=		python:3.10+
> +USES=		python
>  USE_GITHUB=	yes
>  GH_ACCOUNT=	AMDmi3
>  USE_PYTHON=	autoplist distutils noflavors
> @@ -29,4 +29,10 @@ post-install-DOCS-on:
>  do-test:
>  	@cd ${TEST_WRKSRC} && ${SETENV} ${TEST_ENV} ${PYTHON_CMD} -m pytest -v -rs
>  
> -.include <bsd.port.mk>
> +.include <bsd.port.pre.mk>
> +
> +.if ${PYTHON_REL} < 31000
> +IGNORE=		does not yet support python < 3.10
> +.endif
> +
> +.include <bsd.port.post.mk>
> 

-- 
Dmitry Marakasov   .
amdmi3@amdmi3.ru  ..:  https://github.com/AMDmi3  https://amdmi3.ru/