From nobody Wed Oct 13 06:58:47 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 751A41805C75 for ; Wed, 13 Oct 2021 06:59:23 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HTk0q2X2Zz3jL6 for ; Wed, 13 Oct 2021 06:59:23 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 27B70241AF for ; Wed, 13 Oct 2021 06:59:23 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-qv1-f46.google.com with SMTP id n12so1128801qvk.3 for ; Tue, 12 Oct 2021 23:59:23 -0700 (PDT) X-Gm-Message-State: AOAM530/cH5afYPFde9/U0TWqfvZTrhHgMIvL98ctGA1auSnDscICVOM ppndcSZmLb/0KvVQ/i6J3X3maFSbA0nEfJCeuah4EA== X-Google-Smtp-Source: ABdhPJyJOtznKmwcry/aEv6qKkMPEmUZw8YAeoKMd4pmiiJO9aQnrfAoPu3+gyiISStwUpTDzGdUKDUhjNA4WD/oL0w= X-Received: by 2002:ad4:57a9:: with SMTP id g9mr23678711qvx.46.1634108362538; Tue, 12 Oct 2021 23:59:22 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202110071150.197BohT1035282@gitrepo.freebsd.org> <4838ed6d-a2c2-fc69-02ff-0d46a36b0efc@FreeBSD.org> In-Reply-To: <4838ed6d-a2c2-fc69-02ff-0d46a36b0efc@FreeBSD.org> From: Po-Chuan Hsieh Date: Wed, 13 Oct 2021 14:58:47 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 8332894f1a6d - main - devel/py-os-brick: Fix python dependency version. To: Kubilay Kocak Cc: Mikael Urankar , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, python Content-Type: multipart/alternative; boundary="0000000000007954c105ce3680bb" X-ThisMailContainsUnwantedMimeParts: N --0000000000007954c105ce3680bb Content-Type: text/plain; charset="UTF-8" On Mon, Oct 11, 2021 at 6:46 AM Kubilay Kocak wrote: > On 7/10/2021 10:50 pm, Mikael Urankar wrote: > > The branch main has been updated by mikael: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=8332894f1a6d0c128476419235018ca4051b6b1d > > > > commit 8332894f1a6d0c128476419235018ca4051b6b1d > > Author: Mikael Urankar > > AuthorDate: 2021-10-07 11:47:01 +0000 > > Commit: Mikael Urankar > > CommitDate: 2021-10-07 11:50:40 +0000 > > > > devel/py-os-brick: Fix python dependency version. > > > > py-pbr is at version 5.5.0. > > > > Build error: > > py38-os-brick-5.0.0 depends on package: py38-pbr>=5.5.1 - not found > > > > Approved by: portmgr (build fix blanket) > > --- > > devel/py-os-brick/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/devel/py-os-brick/Makefile b/devel/py-os-brick/Makefile > > index 48565419ce94..90b16f4cc483 100644 > > --- a/devel/py-os-brick/Makefile > > +++ b/devel/py-os-brick/Makefile > > @@ -23,7 +23,7 @@ RUN_DEPENDS= > ${PYTHON_PKGNAMEPREFIX}eventlet>=0.30.1:net/py-eventlet@${PY_FLAVOR > > > ${PYTHON_PKGNAMEPREFIX}oslo.serialization>=4.1.0:devel/py-oslo.serialization@${PY_FLAVOR} > \ > > > ${PYTHON_PKGNAMEPREFIX}oslo.service>=2.5.0:devel/py-oslo.service@${PY_FLAVOR} > \ > > > ${PYTHON_PKGNAMEPREFIX}oslo.utils>=4.8.0:devel/py-oslo.utils@${PY_FLAVOR} > \ > > - ${PYTHON_PKGNAMEPREFIX}pbr>=5.5.1:devel/py-pbr@${PY_FLAVOR} > \ > > + ${PYTHON_PKGNAMEPREFIX}pbr>=5.5.0:devel/py-pbr@${PY_FLAVOR} > \ > > ${PYTHON_PKGNAMEPREFIX}requests>=2.25.1:www/py-requests@${PY_FLAVOR} > \ > > ${PYTHON_PKGNAMEPREFIX}tenacity>=6.3.1:devel/py-tenacity@ > ${PY_FLAVOR} > > > > > > Note that changing *_DEPENDS versions without actually patching what > Python packages actually specify and check at runtime (setup.py, or > requirements.txt *if* those are used in setup.py's) wont fix anything, > and will remain broken at runtime. > > In this case os-brick's setup.py specifies: > > setup_requires=['pbr>=2.0.0'], > > And it looks like this port is matching RUN_DEPENDS to requirements.txt, > which specifies >=5.5.1, but requirements.txt is not sourced or used by > setuptools (or setup.py) > > If os-brick actually *requires* 5.5.1 (uses something available only in > 5.5.1), then this package's RUN_DEPENDS is (was) correct and the > setup.py should reflect that (not >=2.0.0). > > If it doesn't require something only in 5.5.1, RUN_DEPENDS should match > what is in setup.py, or whatever the actual minimum dependency > requirement is. > os-brick requires pbr 5.5.1+. I've prepared a patch for pbr 5.6.0 but did not submit the PR yet. The only meaningful difference between pbr 5.5.0 and 5.5.1 is the removal of 2to3 (which is removed in setuptool 58.0.0). Kubilay, do you mind if I update pbr to 5.5.1 now and submit a PR for 5.6.0 later? Then I could change RUN_DEPENDS to match the upstream requirement.txt. Otherwise I'll patch requirement.txt to complete this commit (8332894f1a6d0c128476419235018ca4051b6b1d). Thanks! % grep pbr requirements.txt pbr>=5.5.1 # Apache-2.0 --0000000000007954c105ce3680bb--