From nobody Tue Oct 12 02:02:42 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7A19C1803631; Tue, 12 Oct 2021 02:02:42 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HSzSy33VHz3q8B; Tue, 12 Oct 2021 02:02:42 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1634004162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DmsLtAqzO5h1h3xFSbpRVUlh5fnFbHYJ1eSPC4aJjMI=; b=jtSSRlCv+IO15e9aXUI0d7ypXPEvAskrLzOQodKnCzTRokhmokKyx0os4+QIQp0Cwu42Gr uXA8lOjBm4hfhUecGY8hyoyvwbOVOUtGcABwhkxXHUxU0A5/cEHmG8+v0/mVNi9RowA7xa OuL78jONeCqkpD/bKpu/WuG9w/A7kCgmIPJRrvcy6cId4ACYhEFssuvvq5DGQqISUhSWh5 yKlT0PgJqCrS+DIB7+c8t48IBB025U2qUiakSDhS89T81zA0RpVp2ZNtNJ+fhSH1HkrY2a GGPGxzMxW1iJWkLk6bMkB6uV+p+Y8o5CGWmv8Ok+lV8KXqEOUar1lq1LviJZyQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 50E26B264; Tue, 12 Oct 2021 02:02:42 +0000 (UTC) Date: Tue, 12 Oct 2021 02:02:42 +0000 From: Alexey Dokuchaev To: Bernhard Fr??hlich Cc: Max Brazhnikov , "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" Subject: Re: git: a90e961f4d19 - main - */*: Avoid extra CPE_VENDOR=kde by properly sorting USES Message-ID: References: <202110111458.19BEw4xF062545@gitrepo.freebsd.org> <3067458.bT80LyP3VS@mercury> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1634004162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DmsLtAqzO5h1h3xFSbpRVUlh5fnFbHYJ1eSPC4aJjMI=; b=ezrYk1w5oKV9mS8r+y4MHdks8TLACG5uahmcxNsgTw/t3YtIipIWdFKlvEWYcfNALcroCK i+LPAioD1YTm1HGnDgFMu62JIMgmeuHaejCgS74sc5bYUykqqCnFAb13nJIySXBG+1N7p1 U0OYBpoR2FdrgTCiKz5HjwSS2sVoQ8n4JBrFPptOasthda0Nu5XvXO0VuNj7BM4wpKBNcx u92isPP0lxZdYDlx6wKDtd7nXLXRTCkEXYPUiJ7xJ19Z2NE6a6Er3cxx7E+2IHP6NacoW5 OVcngnlJ4VZcHczmcf48jK/qfjaZbL/SDwAYPmp3uBr3JeGskf033vdU7CETNg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1634004162; a=rsa-sha256; cv=none; b=Ihim67mdMuhLqpLcN5mmamKyT4FHd+QR23zXVFblPUps3Qr10CARJF7KgerVYQYRSAfo9n U75crYcg6zjk9WqECuzPbcB5uUhuPhT69gEv68UVSGQX5rmTxTJyKhlqgF0EqIYR8YpAFr 3OvgFTV/HnnXuh71uZEsgIlziQQgOV6gxmN94Rn+9NMpJ9bBU1yPj+IEXGHKFv9BRt+NR0 1pYLf2jrQ2ayA44XcI3Gb10gbz8M7tU39HST8R4Czla7srdelMgnPkNioVrnqJwu806Z/N gXBwc68v88JEGPIEo41moqUsGw3SibsEyqBx/0YUfQFI+cNZo531X6EnW3WBtA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Mon, Oct 11, 2021 at 09:43:51PM +0200, Bernhard Fr??hlich wrote: > On Monday, October 11, 2021, Max Brazhnikov wrote: > > On Mon, 11 Oct 2021 14:58:04 GMT Bernhard Froehlich wrote: > > > commit a90e961f4d19d53621612d1257a77a5635906ee0 > > > > > > */*: Avoid extra CPE_VENDOR=kde by properly sorting USES > > > > > > CPE_VENDOR=kde is already set in Uses/kde.mk so adding cpe after > > > kde in our USES line makes sure that it's picked up properly. > > > > I believe you shouldn't rely on USES order, it will be broken sooner > > or later. > > Doesn't matter much since CPE data is a moving target anyway. Max' point still stands in general. Sorting various things and knobs alphabetically not only brings neatness and consistency, but also helps to find hidden dependencies and unconvolute or record them properly. ./danfe