git: ad516c14cb - main - Fix HTML validation errors in doc site footer
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 26 Sep 2026 14:19:47 UTC
The branch main has been updated by vladlen:
URL: https://cgit.FreeBSD.org/doc/commit/?id=ad516c14cb6cd63f867bea8ad1d46403e8c700fc
commit ad516c14cb6cd63f867bea8ad1d46403e8c700fc
Author: Vladlen Popolitov <vladlen@FreeBSD.org>
AuthorDate: 2026-09-26 14:19:39 +0000
Commit: Vladlen Popolitov <vladlen@FreeBSD.org>
CommitDate: 2026-09-26 14:19:39 +0000
Fix HTML validation errors in doc site footer
Replace the <h3> column titles with <p class=""column-title""> to stop
validation errors about skipped heading levels on every page, and add
aria-labelledby on each section so the titles are still exposed as
accessible names.
Restore the styling h3 previously received from the browser
(font-weight, line-height, padding) on .column-title so the footer
looks unchanged.
Mirrors the website fix in c33d966fc2.
Reviewed by: carlavilla
Approved by: carlavilla
Differential Revision: https://reviews.freebsd.org/D60040
PR: 297509
---
documentation/themes/beastie/assets/styles/footer.scss | 5 +++++
.../themes/beastie/layouts/_partials/site-footer.html | 18 +++++++++---------
2 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/documentation/themes/beastie/assets/styles/footer.scss b/documentation/themes/beastie/assets/styles/footer.scss
index 3c2af5ceb7..b405117d39 100644
--- a/documentation/themes/beastie/assets/styles/footer.scss
+++ b/documentation/themes/beastie/assets/styles/footer.scss
@@ -81,6 +81,11 @@ footer {
margin-top: 0;
font-size: inherit;
border-bottom: none;
+ margin-bottom: .5rem;
+ font-weight: bold;
+ line-height: 1.3;
+ padding-top: .8rem;
+ padding-bottom: .3rem;
}
.column-elements-container {
diff --git a/documentation/themes/beastie/layouts/_partials/site-footer.html b/documentation/themes/beastie/layouts/_partials/site-footer.html
index 1eecc33af4..46304f285b 100755
--- a/documentation/themes/beastie/layouts/_partials/site-footer.html
+++ b/documentation/themes/beastie/layouts/_partials/site-footer.html
@@ -25,8 +25,8 @@
</div>
</div>
</section>
- <section class="about-column">
- <h3 class="column-title">{{ i18n "f-about" }}</h3>
+ <section class="about-column" aria-labelledby="footer-about-title">
+ <p class="column-title" id="footer-about-title">{{ i18n "f-about" }}</p>
<ul class="column-elements-container">
<li>
<a href="https://www.freebsd.org/about/" target="_blank" class="column-element">{{ i18n "f-freebsd" }}</a>
@@ -45,9 +45,9 @@
</li>
</ul>
</section>
- <section class="documentation-column">
- <h3 class="column-title">{{ i18n "f-documentation" }}</h3>
- <ul class="column-elements-container">
+ <section class="documentation-column" aria-labelledby="footer-documentation-title">
+ <p class="column-title" id="footer-documentation-title">{{ i18n "f-documentation" }}</p>
+ <ul class="column-elements-container">
<li>
<a href="{{ .Site.BaseURL | relLangURL }}" class="column-element">{{ i18n "f-documentation-portal" }}</a>
</li>
@@ -68,8 +68,8 @@
</li>
</ul>
</section>
- <section class="community-column">
- <h3 class="column-title">{{ i18n "f-community" }}</h3>
+ <section class="community-column" aria-labelledby="footer-community-title">
+ <p class="column-title" id="footer-community-title">{{ i18n "f-community" }}</p>
<ul class="column-elements-container">
<li>
<a href={{ "articles/contributing" | absLangURL }} class="column-element">{{ i18n "f-get-involved" }}</a>
@@ -88,8 +88,8 @@
</li>
</ul>
</section>
- <section class="legal-column">
- <h3 class="column-title">{{ i18n "f-legal" }}</h3>
+ <section class="legal-column" aria-labelledby="footer-legal-title">
+ <p class="column-title" id="footer-legal-title">{{ i18n "f-legal" }}</p>
<ul class="column-elements-container">
<li>
<a href="https://freebsdfoundation.org/donate/" target="_blank" class="column-element">{{ i18n "f-donations" }}</a>