Re: git: e7be269af4 - main - Added missing -u flag to pdbedit

From: Daniel Ebdrup Jensen <debdrup_at_FreeBSD.org>
Date: Wed, 03 May 2023 22:37:59 UTC 
On Wed, May 03, 2023 at 10:25:50PM +0000, Daniel Ebdrup Jensen wrote:
>The branch main has been updated by debdrup:
>
>URL: https://cgit.FreeBSD.org/doc/commit/?id=e7be269af4a9f1217b8a185f47f4a642194532d4
>
>commit e7be269af4a9f1217b8a185f47f4a642194532d4
>Author:     Anthony Bravolisimo <freebsd@crontab.pw>
>AuthorDate: 2023-05-03 21:11:39 +0000
>Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
>CommitDate: 2023-05-03 22:25:28 +0000
>
>    Added missing -u flag to pdbedit
>---
> documentation/content/en/books/handbook/network-servers/_index.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/documentation/content/en/books/handbook/network-servers/_index.adoc b/documentation/content/en/books/handbook/network-servers/_index.adoc
>index 2d8b9ca286..1bfbbd85a8 100644
>--- a/documentation/content/en/books/handbook/network-servers/_index.adoc
>+++ b/documentation/content/en/books/handbook/network-servers/_index.adoc
>@@ -2528,7 +2528,7 @@ Map existing FreeBSD user accounts using man:pdbedit[8]:
>
> [source,shell]
> ....
>-# pdbedit -a username
>+# pdbedit -a -u username
> ....
>
> This section has only mentioned the most commonly used settings.

Hi folks,

      Sorry, I forgot to add both context and a note about the PR for
      this commit.

      According to [1], Samba at some point started requiring the -u flag
      for adding and removing users from the SAM database.

      A brief history search through their github repo seems to indicate
      that it predates a CVS conversion some 20 years back, so it's
      unclear for how long it's been required.

      I've added some notes to myself to try and prevent this from
happening again.

Yours apologetically,
Daniel Ebdrup Jensen

1: https://bugs.freebsd.org/270804