Re: git: 71f0bf9790 - main - .vale/styles: Merge spelling-exceptions

From: Moin Rahman <bofh_at_freebsd.org>
Date: Wed, 27 Dec 2023 17:27:49 UTC

> On Dec 27, 2023, at 6:24 PM, John Baldwin <jhb@FreeBSD.org> wrote:
> 
> On 12/23/23 10:42 AM, Moin Rahman wrote:
>>> On Dec 23, 2023, at 7:23 PM, Ceri Davies <ceri@submonkey.net> wrote:
>>> 
>>> 
>>> 
>>>> On 23 Dec 2023, at 11:33, Moin Rahman <bofh@freebsd.org> wrote:
>>>> 
>>>> 
>>>>>> On Dec 23, 2023, at 12:07 PM, Ceri Davies <ceri@submonkey.net> wrote:
>>>>>> 
>>>>>> 
>>>>>>> On 22 Dec 2023, at 14:59, Muhammad Moinur Rahman <bofh@freebsd.org> wrote:
>>>>>> 
>>>>>> +descendents
>>>>> 
>>>>> Although I have not checked for the context in which it is used, this word is almost certainly misspelled as “descendent” is an adjective. The noun “descendants” is most likely the intended use.
>>>> No it's not. The actual word is descendant which can be used as both Noun and Adjective and descendents is the plural of that.
>>> 
>>> That is not correct.  Pluralising a noun by adding an “s” does not frequently - or ever, as far as I can think - change the spelling of the rest of a word.
>>> 
>>> “Descendent”, as I said, is an adjective and the plural of “descendant” is “descendants”.
>> At the moment I am not in the state to fight over a word. If you think the word is wrong please find the origin in the doc tree and submit a review or commit it.
> 
> Ceri is right on this one.  Not many hits via `git grep` for the misspelling:
> 
> vale/styles/Vocab/Terms/accept.txt:descendents
> documentation/content/en/books/design-44bsd/_index.adoc:Mechanisms are provided by the kernel to allow a process to alter its process group or the process group of its descendents.
> documentation/content/en/books/design-44bsd/_index.po:"process to alter its process group or the process group of its descendents.  "
> website/static/security/patches/EN-19:03/sqlite-11.patch:+** Return a JsonNode and all its descendents as a JSON string.
> website/static/security/patches/EN-19:03/sqlite-11.patch:-** Return a JsonNode and all its descendents as a JSON string.
> website/static/security/patches/EN-19:03/sqlite-12.patch:+** Return a JsonNode and all its descendents as a JSON string.
> website/static/security/patches/EN-19:03/sqlite-12.patch:-** Return a JsonNode and all its descendents as a JSON string.
> 
> I can fix the design-44bsd doc, but not sure how that affects the *.po files?
> 
> The patches shouldn't be changed as that's just a typo in the upstream sqlite
> sources.
> 
> --
> John Baldwin

Normally we do not run vale on po or patch files. We only run it on .adoc files. While you fix it do not forget to remove the word from .vale/styles/Vocab/Terms/accept.txt as it will be no longer required.

Kind regards,
Moin