From nobody Thu Oct 07 21:59:44 2021 X-Original-To: dev-commits-doc-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8BE5F12D6041 for ; Thu, 7 Oct 2021 22:00:06 +0000 (UTC) (envelope-from dbaio@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HQQGt36S4z3F28; Thu, 7 Oct 2021 22:00:06 +0000 (UTC) (envelope-from dbaio@FreeBSD.org) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: dbaio/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 45A5B2C237; Thu, 7 Oct 2021 22:00:06 +0000 (UTC) (envelope-from dbaio@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id E336E27C0060; Thu, 7 Oct 2021 18:00:05 -0400 (EDT) Received: from imap42 ([10.202.2.92]) by compute4.internal (MEProxy); Thu, 07 Oct 2021 18:00:05 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelledgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderredtnecuhfhrohhmpedfffgrnhhilhhoucfirdcuuegrihhofdcuoegusggrihho sefhrhgvvgeuufffrdhorhhgqeenucggtffrrghtthgvrhhnpeelffegvefgffehveektd ffheegudefieeghfeiuddvieekkeffieffjeeguedtveenucffohhmrghinhepfhhrvggv sghsugdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegusggrihhoodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduudek udefleduvddtqddvieektddvjeeikedquggsrghioheppefhrhgvvgeuufffrdhorhhgse hfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id C07622180078; Thu, 7 Oct 2021 18:00:05 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-1331-g5ae342296a-fm-20211005.001-g5ae34229 List-Id: Commit messages for all branches of the doc repository List-Archive: https://lists.freebsd.org/archives/dev-commits-doc-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-doc-all@freebsd.org X-BeenThere: dev-commits-doc-all@freebsd.org Mime-Version: 1.0 Message-Id: In-Reply-To: References: <202110062359.196NxFqS079143@gitrepo.freebsd.org> <0595c299-55ed-17c4-74ac-16a804541473@FreeBSD.org> <20211007205425.j4idybl7jrtwxeal@t480.local> Date: Thu, 07 Oct 2021 18:59:44 -0300 From: "Danilo G. Baio" To: "John Baldwin" Cc: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org Subject: Re: git: 5a5db32f4a - main - Fix build after c8e8be58e580 Content-Type: text/plain X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N On Thu, Oct 7, 2021, at 18:20, John Baldwin wrote: > On 10/7/21 1:54 PM, Danilo G. Baio wrote: >> On Thu, Oct 07, 2021 at 09:22:56AM -0700, John Baldwin wrote: >>> On 10/6/21 4:59 PM, Danilo G. Baio wrote: >>>> The branch main has been updated by dbaio: >>>> >>>> URL: https://cgit.FreeBSD.org/doc/commit/?id=5a5db32f4a1e3f507cdc55f92d53e63adbb4f022 >>>> >>>> commit 5a5db32f4a1e3f507cdc55f92d53e63adbb4f022 >>>> Author: Danilo G. Baio >>>> AuthorDate: 2021-10-06 23:57:27 +0000 >>>> Commit: Danilo G. Baio >>>> CommitDate: 2021-10-06 23:57:27 +0000 >>>> >>>> Fix build after c8e8be58e580 >>> >>> It used to be possible to use 'make' in individual books or articles to test >>> things, and also to only build just html versions and not be required to >>> build PDF. Apparently our new system doesn't permit either of those, so I >>> gave up on trying to test this pre-commit. >>> >>> -- >>> John Baldwin >> >> >> To speed up the build time (right now), you can build only English HTML >> documentation this way: >> >> $ cd documentation >> $ DOC_LANG="en" make >> >> 14 seconds here >> against 2 minutes for all languages. >> >> The `make run` also helps as pointed by Sergio. >> >> >> ps. PDF is not built automatically. > > I tried plain 'make' at the documentation top-level and it failed due to missing > asciidoctor-pdf (I had built docproj with PDF unchecked). > > I have used 'make' just fine for the website in the past. The error message > came from the 'requirements' target in documentation/Makefile: > > RUN_DEPENDS= ${PYTHON_CMD} \ > ${HUGO_CMD} \ > ${LOCALBASE}/bin/asciidoctor \ > ${LOCALBASE}/bin/asciidoctor-pdf \ > ${LOCALBASE}/bin/rougify > > ... > > all: requirements starting-message generate-books-toc > generate-pgpkeys-txt build > run: requirements starting-message generate-books-toc > generate-pgpkeys-txt run-local > > ... > > requirements: > .for dep in ${RUN_DEPENDS} > .if !exists(${dep}) > @(echo ${dep} not found, please run 'pkg install docproj > python3'; exit 1) > .endif > .endfor > > Thus, even using 'make html' or 'make run' will fail if the PDF tools > aren't installed > even though those make targets don't generate PDF. > > The problem for me wasn't the build time, it was the explicit error and > exit above. > > -- > John Baldwin ah got it. I misunderstood the main issue. we need to fix this requirement. and thanks for pointing that out. -- Danilo G. Baio