Re: FreeBSD-main-amd64-gcc13_build - Build #2837 - Still Failing

hi!

markj filed a review - https://reviews.freebsd.org/D48903

We're talking about what/how to fix

thanks!


-a


On Sun, 9 Feb 2025 at 05:47, Eygene Ryabinkin <rea@freebsd.org> wrote:

> Gentlemen, good day.
>
> Jenkins passed me the following build errors, since I had receintly
> committed to the HEAD (ports-committers.dot).  My commit was unrelated
> to those build failures, but attached is the patch that fixes
> the code of mtw_mcu_radio(): it passes wrond 3-rd argument to the
> mtw_mcu_cmd().  Also checked that other invocations of mtw_mcu_cmd()
> are fine.
>
> jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:03:21PM
> +0000:
> > FreeBSD-main-amd64-gcc13_build - Build #2837
> (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing
> >
> > Build information:
> https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/
> > Full change log:
> https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/changes
> > Full build log:
> https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/console
> >
> > Change summaries:
> > (Those commits are likely but not certainly responsible)
> >
> > c945a7832f94c6a46375596f298f6140640722cd by rea:
> > Ports committers: add myself
> >
> >
> >
> > The end of the build log:
> >
> > [...truncated 126.38 MiB...]
> [...]
> > --- all_subdir_usb/mtw ---
> > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27:
> > In function 'mtw_mcu_cmd',
> >     inlined from 'mtw_mcu_radio' at
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10,
> >     inlined from 'mtw_init_locked' at
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2,
> >     inlined from 'mtw_parent' at
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3:
> > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy'
> forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with
> type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds=]
> >   283 | #define memcpy(to, from, len)   __builtin_memcpy((to), (from),
> (len))
> >       |
>  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of
> macro 'memcpy'
> >  1407 |         memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len);
> >       |         ^~~~~~
> > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent':
> > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4390:1: note: 'val' declared
> here
> >  4390 | mtw_init_locked(struct mtw_softc *sc)
> >       | ^~~~~~~~~~~~~~~
>
>
> jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:16:17PM
> +0000:
> > FreeBSD-main-amd64-gcc12_build - Build #4957
> (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing
> >
> > Build information:
> https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/
> > Full change log:
> https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/changes
> > Full build log:
> https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/console
> >
> > Change summaries:
> > (Those commits are likely but not certainly responsible)
> >
> > c945a7832f94c6a46375596f298f6140640722cd by rea:
> > Ports committers: add myself
> >
> >
> >
> > The end of the build log:
> >
> > [...truncated 125.71 MiB...]
> [...]
> > --- all_subdir_usb/mtw ---
> > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27:
> > In function 'mtw_mcu_cmd',
> >     inlined from 'mtw_mcu_radio' at
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10,
> >     inlined from 'mtw_init_locked' at
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2,
> >     inlined from 'mtw_parent' at
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3:
> > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy'
> forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with
> type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds]
> >   283 | #define memcpy(to, from, len)   __builtin_memcpy((to), (from),
> (len))
> >       |
>  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of
> macro 'memcpy'
> >  1407 |         memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len);
> >       |         ^~~~~~
> > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent':
>
> Please, review and, possibly, commit.
>
> Thank you.
> --
> rea
>