Re: FreeBSD-main-amd64-test_zfs CI job still required?

> On Apr 12, 2023, at 12:49 PM, Michal Scigocki <michal.os@hotmail.com> wrote:
> 
> Hi,
> 
> The "FreeBSD-main-amd64-test_zfs" CI Jenkins job has been failing on
> ci.freebsd.org for over a year now, is this CI job is still required?
> 
> Currently the job terminates before running any tests due to the
> bhyve configuration in the CI job "build.sh" script.
> 
> The patch below should repair the CI job to enable the tests to start,
> however in my local testing one zfs test causes a kernel panic and
> kyua aborts the test run.
> 
> The kernel panic test case is "tests/zil/zil_test:zil_002_pos".
> 
> I was able to run the other remaining tests on my local setup.
> 
> Regards,
> Michal Scigocki
> 
> 
> --- freebsd-ci/jobs/FreeBSD-main-amd64-test_zfs/build.sh	2023-04-11 08:08:54.888912000 +1000
> +++ freebsd-ci/jobs/FreeBSD-main-amd64-test_zfs/build.01.sh	2023-04-12 06:39:49.144240000 +1000
> @@ -37,12 +37,12 @@
>  for i in `jot ${EXTRA_DISK_NUM}`; do
> 	truncate -s ${EXTRA_DISK_SIZE} disk${i}
> -	BHYVE_EXTRA_DISK_PARAM="${BHYVE_EXTRA_DISK_PARAM} -s $((i + 3)):0,ahci-hd,disk${i}"
> +	BHYVE_EXTRA_DISK_PARAM="${BHYVE_EXTRA_DISK_PARAM} -s $((i + 3)):0,virtio-blk,disk${i}"
> done
>  DISK_TMP=disktmp
> truncate -s 32G ${DISK_TMP}
> -BHYVE_EXTRA_DISK_PARAM="${BHYVE_EXTRA_DISK_PARAM} -s $((${EXTRA_DISK_NUM} + 4)):0,ahci-hd,${DISK_TMP}"
> +BHYVE_EXTRA_DISK_PARAM="${BHYVE_EXTRA_DISK_PARAM} -s $((${EXTRA_DISK_NUM} + 4)):0,virtio-blk,${DISK_TMP}"
>  # prepare meta disk to pass information to testvm
> rm -fr ${METADIR}
> @@ -65,8 +65,8 @@
> 	-c 2 -m ${TEST_VM_MEMORY} -A -H -P \
> 	-s 0:0,hostbridge \
> 	-s 1:0,lpc \
> -	-s 2:0,ahci-hd,${IMG_NAME} \
> -	-s 3:0,ahci-hd,meta.tar \
> +	-s 2:0,virtio-blk,${IMG_NAME} \
> +	-s 3:0,virtio-blk,meta.tar \
> 	${BHYVE_EXTRA_DISK_PARAM} \
> 	-l com1,stdio \
> 	${TEST_VM_NAME}; \
> 

Hi,

Can you submit a pull request at Github? Which is easier to handle and safe to patch.

Kind regards,
Moin