Re: cvs commit: src/sys/netinet tcp_input.c

From: John-Mark Gurney <gurney_j_at_resnet.uoregon.edu>
Date: Mon, 25 Sep 2006 21:14:07 -0700
Andrew R. Reiter wrote this message on Mon, Sep 25, 2006 at 21:53 -0400:
> On Tue, 26 Sep 2006, John-Mark Gurney wrote:
> 
> :jmg         2006-09-26 01:21:47 UTC
> :
> :  FreeBSD src repository
> :
> :  Modified files:
> :    sys/netinet          tcp_input.c 
> :  Log:
> :  fix calculating to_tsecr...  This prevents the rtt calculations from
> :  going all wonky...
> :  
> :  Revision  Changes    Path
> :  1.309     +1 -1      src/sys/netinet/tcp_input.c
> 
> At some point will it be safe to remove that min/max check?  

Do you mean replace the else? or do you mean change it entirely?

Unless someone can think of a reason why the retransmit timer should
ever be allowed to go above 64 seconds, I'd consider replacing the
else, but as I see it, it prevents run away code, though w/o the
else I probably wouldn't of found this bug...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."
Received on Tue Sep 26 2006 - 04:14:11 UTC