Re: cvs commit: src/sys/kern kern_proc.c

From: John Baldwin <jhb_at_freebsd.org>
Date: Wed, 20 Sep 2006 19:02:45 -0400
On Wednesday 20 September 2006 13:23, Martin Blapp wrote:
> 
> >>                  mtx_init(&sess->s_mtx, "session", NULL, MTX_DEF);
> >>                  PROC_LOCK(p);
> >>                  p->p_flag &= ~P_CONTROLT;
> >>                  PROC_UNLOCK(p);
> >>                  PGRP_LOCK(pgrp);
> >>                  sess->s_leader = p;
> >>                  sess->s_sid = p->p_pid;
> >>                  sess->s_count = 1;
> >>                  sess->s_ttyvp = NULL;
> >>                  sess->s_ttyp = NULL;
> 
> So we need GIANT too after the text 'else' ... What do you think ?
> 
> > Well, I'd rather use whatever lock we end up using for t_session instead
> > of assuming it's going to be proctree_lock, so I'd like to leave t_session
> > only under Giant for now until we really know what we are doing.
> 
> Ok. Should I back out tty.c rev. v. 1.258 or just going to work on the tty
> lock directly and replace it with whatever lock we use in CURRENT ? I'll only
> MFC the other part ...

I would back it out for now so it doesn't trip up someone else wandering
through the code in the interim between now and working TTY locking.

-- 
John Baldwin
Received on Wed Sep 20 2006 - 23:04:24 UTC