Re: cvs commit: ports/x11/menu-cache Makefile

From: Kris Moore <kris_at_pcbsd.org>
Date: Sat, 02 Oct 2010 23:30:51 -0400
"Sunpoet Po-Chuan Hsieh" <sunpoet_at_sunpoet.net> wrote:

>On Sat, Oct 02, 2010 at 05:27:53PM +0000, Alexey Dokuchaev wrote:
>> On Fri, Oct 01, 2010 at 02:50:54PM +0000, Kris Moore wrote:
>> > kmoore      2010-10-01 14:50:54 UTC
>> > 
>> >   FreeBSD ports repository
>> > 
>> >   Modified files:
>> >     x11/menu-cache       Makefile 
>> >   Log:
>> >   Fix install of pkgconfig data
>> 
>> `post-configure' target name suggests that Makefile.in's can be omitted
>> from that code, since the patch is applied to generated files anyway, no?
>> 
>> ./danfe
>
>Hi,
>
>To the best of my knowledge, we usually do *.in modification BEFORE
>configure: (e.g. post-patch:). Furthermore, the replacement looks like
>what USE_GNOME=gnomehack does to Makefile.in. 
>
>I have tested the following cases:
>1. Based on Makefile r1.2, change post-configure: to post-patch:
>2. Add USE_GNOME=gnomehack and remove post-configure:
>The "make patch" results are identical. (except .bak files)
>
>I did not add this port to tinderbox due to a long package-depends-list
>(67 ports). But I believe the following patch should work fine.
>
>Kris, Would you please check if everything is OK with the attached patch?
>Thanks.
>
>Regards,
>sunpoet
>-- 
>          4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B  8CC0 DC44 247E CC57 E36B
>  Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net>, <sunpoet at FreeBSD.org>

Fix passes tindy just fine here, committed a moment ago. Thanks for the suggestion! 

-- 
Kris Moore 
PC-BSD / iXsystems 
Received on Sun Oct 03 2010 - 03:48:18 UTC