Re: cvs commit: ports/x11/menu-cache Makefile
On Sat, Oct 02, 2010 at 05:27:53PM +0000, Alexey Dokuchaev wrote:
> On Fri, Oct 01, 2010 at 02:50:54PM +0000, Kris Moore wrote:
> > kmoore 2010-10-01 14:50:54 UTC
> > FreeBSD ports repository
> > Modified files:
> > x11/menu-cache Makefile
> > Log:
> > Fix install of pkgconfig data
> `post-configure' target name suggests that Makefile.in's can be omitted
> from that code, since the patch is applied to generated files anyway, no?
To the best of my knowledge, we usually do *.in modification BEFORE
configure: (e.g. post-patch:). Furthermore, the replacement looks like
what USE_GNOME=gnomehack does to Makefile.in.
I have tested the following cases:
1. Based on Makefile r1.2, change post-configure: to post-patch:
2. Add USE_GNOME=gnomehack and remove post-configure:
The "make patch" results are identical. (except .bak files)
I did not add this port to tinderbox due to a long package-depends-list
(67 ports). But I believe the following patch should work fine.
Kris, Would you please check if everything is OK with the attached patch?
4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net>, <sunpoet at FreeBSD.org>
Received on Sat Oct 02 2010 - 20:58:54 UTC
- application/pgp-signature attachment: stored