Re: cvs commit: ports/editors/emacs-devel Makefile distinfo ports/editors/emacs-devel/files patch-configure

From: Ashish SHUKLA <>
Date: Sun, 01 May 2011 05:18:21 +0530
Pan Tsu writes:
> Ashish SHUKLA <> writes:

>> ashish      2011-04-28 15:08:25 UTC
>> FreeBSD ports repository
>> Modified files:
>> editors/emacs-devel  Makefile distinfo 
>> editors/emacs-devel/files 
>> Added files:
>> editors/emacs-devel/files 
>> Removed files:
>> editors/emacs-devel/files patch-configure 
>> Log:
>> - Update to bzr revision 104000.

> - Any reason to use instead of relying on AUTOTOOLS?

Because works fine, and is provided by the upstream to configure
the sources. So, I prefer to use upstream, unless it behaves badly.

> - Why was lost and not converted to

As I see, in src/ (excerpt is pasted below) which get generated
already includes "stdlib.h", so I don't see any need of the re-including it,
unless you think it causes some issue.

--8<---------------cut here---------------start------------->8---
/* Define if the compiler supports function prototypes.  It may do so but
   not define __STDC__ (e.g. DEC C by default) or may define it as zero.  */

#include <string.h>
#include <stdlib.h>

# include <alloca.h>
#elif defined __FreeBSD__
#include <stdlib.h>
#elif defined __GNUC__
# define alloca __builtin_alloca
#elif defined _AIX
# define alloca __alloca
# include <stddef.h>
# ifdef  __cplusplus
extern "C"
# endif
void *alloca (size_t);
--8<---------------cut here---------------end--------------->8---

> - No love for IMAGEMAGICK knob since

My sincere apologies for missing this diff, I'll include it, test it, and
commit it today hopefully.

Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0!ashish |

Avoid Success At All Costs !!

Received on Sat Apr 30 2011 - 23:48:44 UTC