Re: cvs commit: ports/www/chromium Makefile

From: Alexey Dokuchaev <danfe_at_FreeBSD.org>
Date: Fri, 8 Apr 2011 03:54:30 +0000
On Fri, Apr 08, 2011 at 03:47:07AM +0000, b. f. wrote:
> On 4/8/11, Alexey Dokuchaev <danfe_at_freebsd.org> wrote:
> > On Fri, Apr 08, 2011 at 02:24:59AM +0000, Alexey Dokuchaev wrote:
> >> I've been thinking about this as well.  However, instead of bringing back
> >> this OPTION, I'd suggest adding "|| defined(PACKAGE_BUILDING)" to that
> >> .if to ensure that packages are can be safely run on pre-SSE2 CPUs.
> >
> > Diff attached, seems to DTRT.
> 
> Someone may want to build SSE2-enabled packages for i386 in a
> tinderbox or on a package-building machine, and the option allows them
> to do this, but this change does not.  Also, with this change, you're
> telling the configure script to disable SSE2 when PACKAGE_BUILDING is
> defined even on amd64, where SSE2 is always available.  So I don't
> think it DTRT.

One can always pass desired CPUTYPE is they want to build their package
with specific target.  As for amd64, here I agree, checking for ARCH
makes sence.  I don't mind this heuristics, as long as there is no SSE
option.  OPTIONS like this are bad since they are cached and can stay
unnoticed for long periods of time.

On the other hand, Chromium is web browser, which it most likely is going
to be used on users' desktop, where SSE2 is probably feels like home for
a while already.  :-)

./danfe
Received on Fri Apr 08 2011 - 03:54:30 UTC