Re: cvs commit: ports/www/chromium Makefile

From: b. f. <bf1783_at_googlemail.com>
Date: Fri, 8 Apr 2011 03:47:07 +0000
On 4/8/11, Alexey Dokuchaev <danfe_at_freebsd.org> wrote:
> On Fri, Apr 08, 2011 at 02:24:59AM +0000, Alexey Dokuchaev wrote:
>> I've been thinking about this as well.  However, instead of bringing back
>> this OPTION, I'd suggest adding "|| defined(PACKAGE_BUILDING)" to that
>> .if to ensure that packages are can be safely run on pre-SSE2 CPUs.
>
> Diff attached, seems to DTRT.

Someone may want to build SSE2-enabled packages for i386 in a
tinderbox or on a package-building machine, and the option allows them
to do this, but this change does not.  Also, with this change, you're
telling the configure script to disable SSE2 when PACKAGE_BUILDING is
defined even on amd64, where SSE2 is always available.  So I don't
think it DTRT.

b.
Received on Fri Apr 08 2011 - 03:47:08 UTC