Re: cvs commit: ports/editors/emacs Makefile

From: Giorgos Keramidas <keramida_at_freebsd.org>
Date: Sat, 22 May 2010 15:06:52 +0300
On Sat, 22 May 2010 19:16:22 +0900, Hajimu UMEMOTO <ume_at_FreeBSD.org> wrote:
> Hi,
>
>>>>>> On Sat, 22 May 2010 08:49:46 +0000
>>>>>> Alexey Dokuchaev <danfe_at_FreeBSD.org> said:
>
> danfe> Having `-nox11' suffixed ports nowadays (when we have OPTIONS framework
> danfe> stable and mature enough) is mostly archaic, and can in fact be
> danfe> confusing (like in this case).  Previously, having the possibility to
> danfe> build non-graphic version of their editor without having to explicitly
> danfe> pass -DWITHOUT_X11 option was valued by some of us, but today preferred
> danfe> OPTIONS are cached between updates in /var/db/ports/, so it's really the
> danfe> same level of convenience without the need for slave port.  Especially
> danfe> when it does not play well with master.  Suffixed slaves are almost
> danfe> entirely limited to be useful only for non-OPTIONS ports these days.
>
> Yes, I think so, too.  However, someone else want to have a slave port
> for an OPTIONS port, in general.  So, it is worth having a framework
> for such needs, IMHO.
>
> danfe> One might argue that it's convenient to have -nox11 *package*, but in
> danfe> this case special care must be taken (lurk for BATCH and
> danfe> PACKAGE_BUILDING knobs in bpm).  I would probably just went ahead and
> danfe> killed `editors/emacs-nox11' port and be done with it, if anyone asks.
>
> Though I myself always build from ports and don't use packages, having
> -nox11 package for emacs is good thing, IMHO.
> I'm not sure how useful emacs with DBUS without X11 is.  Actually, I'm
> using emacs without both X11 and DBUS.  How about disabling both, for
> now?
>
> Index: emacs-nox11/Makefile
> diff -u emacs-nox11/Makefile.orig emacs-nox11/Makefile
> --- emacs-nox11/Makefile.orig	2010-05-22 16:49:34.528548000 +0900
> +++ emacs-nox11/Makefile	2010-05-22 19:09:24.284033237 +0900
> _at__at_ -5,14 +5,12 _at__at_
>  # $FreeBSD: ports/editors/emacs-nox11/Makefile,v 1.3 2010/05/21 19:49:46 keramida Exp $
>  #
>
> +BATCH=		yes
> +WITHOUT_DBUS=	yes
>  WITHOUT_X11=    yes
>  PKGNAMESUFFIX=	-nox11
>
>  MASTERDIR=      ${.CURDIR}/../emacs
>  LATEST_LINK=	emacs-nox11
>
> -#.if ${OSVERSION} < 700000 && defined(WITH_DBUS)
> -#BROKEN= Does not currently build with dbus support
> -#.endif
> -
>  .include "${MASTERDIR}/Makefile"

This looks nice. Let's pass it through the new maintainer of emacs*
ports and commit it if Ashish does not object.


Received on Sat May 22 2010 - 12:07:13 UTC