Re: cvs commit: ports/editors/emacs Makefile
On Sat, 22 May 2010 06:37:51 +0000, Alexey Dokuchaev <danfe_at_FreeBSD.org> wrote:
> On Sat, May 22, 2010 at 08:52:03AM +0300, Giorgos Keramidas wrote:
>> Does this patch look ok?
> No, it does not. PORTEPOCH could never go backwards or be reset. It is
> the way we deal when version scheme changes so "newer" version is less
> than "old", or when for some reason port must be downgraded (yes, these
> things happen from time to time).
> You should have bumped PORTREVISION (wraps every version update, thus
> being cheap), but now it's probably too late: accidental errors like
> this should normally be reverted in a matter of minutes.
> Please refer to relevant PHB chapters for gory details, and be careful
> next time.
Argh. So can we just commit the bsd.port.pre.mk bits? The OSVERSION
check is important for 6.X users.
Received on Sat May 22 2010 - 07:21:29 UTC