Re: cvs commit: src/sys/i386/cpufreq est.c

From: Rui Paulo <rpaulo_at_FreeBSD.org>
Date: Thu, 01 May 2008 22:20:06 +0100
John Baldwin wrote:
> On Thursday 28 February 2008 02:10:42 pm Rui Paulo wrote:
>> rpaulo      2008-02-28 19:10:42 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/i386/cpufreq     est.c 
>>   Log:
>>   Validate the id16 values gathered from ACPI (previously a TODO item).
>>   Style changes by me and njl.
> 
> What is the purpose of the 'saved_id16' variable?  It is never used.  I think 
> what might be better is to just read it once at the start of the loop and 
> then restore it at the end of the loop, though phk_at_ has overwritten this with 
> the "chew up all battery on laptops at all cost" patch. :-P
> 

What do you mean by 'It is never used.' ?

% cat -n est.c | grep saved_id16
   1082		uint16_t saved_id16;
   1111				est_get_id16(&saved_id16);

-- 
Rui Paulo
Received on Thu May 01 2008 - 21:20:16 UTC