Re: cvs commit: ports/mail/libvmime Makefile

From: Pav Lucistnik <pav_at_FreeBSD.org>
Date: Wed, 23 Jul 2008 12:26:36 +0200
Xin LI pÝ╣e v st 23. 07. 2008 v 03:21 -0700:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Pav Lucistnik wrote:
> | Xin LI pÝ╣e v ˙t 22. 07. 2008 v 19:19 -0700:
> |> -----BEGIN PGP SIGNED MESSAGE-----
> |> Hash: SHA1
> |>
> |> Pav Lucistnik wrote:
> |> | pav         2008-07-23 00:57:45 UTC
> |> |
> |> |   FreeBSD ports repository
> |> |
> |> |   Modified files:
> |> |     mail/libvmime        Makefile
> |> |   Log:
> |> |   - Mark BROKEN: does not compile with gnutls-2.4.x
> |>
> |> Er, why, how can we say this version of gnutls is not broken when they
> |> have this?
> |>
> |> ~  typedef enum gnutls_certificate_print_formats
> |> ~    {
> |> ~      GNUTLS_CRT_PRINT_FULL,
> |> ~      GNUTLS_CRT_PRINT_ONELINE,
> |> ~      GNUTLS_CRT_PRINT_UNSIGNED_FULL,   // extra ","
> |> ~    } gnutls_certificate_print_formats_t;
> |
> | I don't mind if it's fixed in libvmime or in gnutls port, as long as it
> | get fixed.
> 
> Unfortunately this can *NOT* be fixed in libvmime because gnutls's
> include file is broken.  By making an instance of
> gnutls_certificate_print_formats_t the compiler would notice the problem
> immediately.
> 
> | BTW it's still this way in gnutls git.
> 
> I have submitted ticket #770 on gnutls trac.  Just because it is still
> in gnutls git does not mean that it is correct.  Can we fix the (broken)
> security/gnutls, rather than mark (the non-broken) libvmime broken?  The
> port works just fine with patched gnutls.

I'm all for it. Guess it depends on gnutls port maintainer now.

-- 
Pav Lucistnik <pav_at_oook.cz>
              <pav_at_FreeBSD.org>

Can't sing. Can't dance. Can handle a sword a little.

Received on Wed Jul 23 2008 - 10:26:53 UTC