Re: cvs commit: ports/devel/dmucs Makefile ports/devel/dmucs/files patch-dmucs_db.cc patch-dmucs_db.h patch-dmucs_msg.cc patch-main.cc

From: Pietro Cerutti <gahr_at_FreeBSD.org>
Date: Mon, 07 Jul 2008 18:37:09 +0200
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Max Khon wrote:
| fjoe        2008-07-07 16:17:54 UTC
|
|   FreeBSD ports repository
|
|   Modified files:
|     devel/dmucs          Makefile
|   Added files:
|     devel/dmucs/files    patch-dmucs_db.cc patch-dmucs_db.h
|                          patch-dmucs_msg.cc patch-main.cc
|   Log:
|   Unbreak on 64-bit archs

I definitely do not agree. Please note that a pointer is not required to
fit into a long, while it is required to fit into a size_t.

Your solution may work as soon as we are concerned only with LP64
machines. As soon as a LLP64 arch steps in, you break things.


- --
Pietro Cerutti
gahr_at_FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEAREKAAYFAkhyRjQACgkQwMJqmJVx944GaACfflIfNyx5oGSPB4FZL69bqLaC
T24An2cfRKJYWt2dSBpJIiMB9ylgrscy
=XYtC
-----END PGP SIGNATURE-----
Received on Mon Jul 07 2008 - 16:37:16 UTC