Re: cvs commit: src/sys/dev/usb umass.c

From: M. Warner Losh <imp_at_bsdimp.com>
Date: Wed, 28 Feb 2007 03:12:05 -0700 (MST)
In message: <200702281302.18223.doconnor_at_gsoft.com.au>
            "Daniel O'Connor" <doconnor_at_gsoft.com.au> writes:
: On Wednesday 28 February 2007 09:03, Warner Losh wrote:
: >   Create a new quirk READ_CAPACITY_OFFBY1 and add a quirk for the
: >   SanDISK ImageMate that I have that suffers from this problem (the
: >   SDDR-31).  It intercepts the READ_CAPACITY response and adjusts it
: >   from number of sectors to max sector for devices with this quirk.
: >
: >   Reading the Linux source suggests that there are a host of
: >   other devices with this issue, including iPods and some popular
: >   cameras.  I've not added quirks for them, since I don't have the
: >   devices in front of me to test.
: 
: Couldn't you automatically test for this? ie try and read the last sector.
: 
: Obviously if there is a real error in the last sector you'd get a bogus result 
: but I don't think that is likely to be very common :)

To amplify my last answer:

No.  I couldn't automatically test for this.  Others can submit
patches if they want it.

Warner
Received on Wed Feb 28 2007 - 10:14:02 UTC