Re: cvs commit: src/sys/dev/digi digi.c src/sys/kern kern_linker.c subr_firmware.c src/sys/sys linker.h
On Thu, 15 Feb 2007 21:01:57 +0100 Max Laier <max_at_love2party.net> wrote:
> On Thursday 15 February 2007 20:49, Luigi Rizzo wrote:
> > luigi 2007-02-15 19:49:27 UTC
> > FreeBSD src repository
> > Modified files: (Branch: RELENG_6)
> > sys/dev/digi digi.c
> > sys/kern kern_linker.c subr_firmware.c
> > sys/sys linker.h
> > Log:
> > MFC kern_linker.c 1.133 and related changes:
> > - push Giant into linker_reference_module();
> > - introduce linker_release_module(), which also takes care of
> > proper locking.
> > The latter also fixes a missing mtx_loc/unlock in subr_firmware.c .
> > Apparently, digi.c is the only external client of
> > linker_reference_module() which is a bit suspicious - perhaps dev/digi/
> > could make with a bit of review from someone knowledgeable to check how
> > the function is used, and whether it could be replaced by something
> > else.
> I have a version of digi(4) in perforce that uses firmware(9). I couldn't
> find testers, but with a bit of review this should be committable
> > Revision Changes Path
> > 188.8.131.52 +3 -3 src/sys/dev/digi/digi.c
> > 184.108.40.206 +31 -1 src/sys/kern/kern_linker.c
> > 220.127.116.11 +1 -3 src/sys/kern/subr_firmware.c
> > 18.104.22.168 +8 -0 src/sys/sys/linker.h
> /"\ Best regards, | mlaier_at_freebsd.org
> \ / Max Laier | ICQ #67774661
> X http://pf4freebsd.love2party.net/ | mlaier_at_EFnet
> / \ ASCII Ribbon Campaign | Against HTML Mail and News
I could probably do some testing here - I have some digi
cards (although only one PCI one AFAIR!!).
I originally added linker_reference_module() because I
wanted to be able to dynamically load a module from
another module, or take a reference to it if it's
already there. This was a good way to load/unload the
different firmware types after figuring out what the
card type is.
If firmware(9) avoids this necessity, I'm all for doing
away with linker_reference_module().
Brian Somers <brian_at_Awfulhak.org>
Don't _EVER_ lose your sense of humour ! <brian_at_FreeBSD.org>
Received on Sun Feb 18 2007 - 13:28:49 UTC