Re: cvs commit: src/sys/dev/em if_em.c if_em.h

From: Andre Oppermann <andre_at_freebsd.org>
Date: Fri, 04 Aug 2006 17:44:11 +0200
Prafulla Deuskar wrote:
> Gleb Smirnoff [glebius_at_FreeBSD.org] wrote:
>>   Prafulla,
>>
>> On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote:
>> P> pdeuskar    2006-08-03 19:05:05 UTC
>> P> 
>> P>   FreeBSD src repository
>> P> 
>> P>   Modified files:
>> P>     sys/dev/em           if_em.c if_em.h 
>> P>   Log:
>> P>   Revert back changes to made in rev 1.109 of if_em.c which were unnecessary.
>> P>   This makes it easier for us to get the changes into -current and to -stable quickly.
>>
>> Can you please confirm that this was a mechanical substitution like this:
>>
>> s/sc/adapter/g
>> s/em_softc/adapter/g
>>
>> and no more additional changes? If this is true, then I hope that we
>> (FreeBSD and Intel) have finally came to a common codebase. This is good. :)
>> I can stand the long unusual name for driver softc with no problems.
>>
>> I'm only a bit disappointed by the fact, that I haven't received a single
>> email about these plans. You were in the void for a long time, and
>> then began your work with a commit, w/o informing people who were
>> maintaining driver while the vendor maintanance was on a hiatus.
>>
> 
> Yes - it was a mechanical substitution.

According to jb_at_freebsd.org at least one non-mechanical change slipped
in breaking his Sun4v box.  AFAIR some fix in/with bus_dmamap_unload()
was reverted.

-- 
Andre
Received on Fri Aug 04 2006 - 15:44:16 UTC