Re: cvs commit: ports/devel/gnomevfs2 Makefile

From: Joe Marcus Clarke <marcus_at_FreeBSD.org>
Date: Mon, 10 Jan 2005 04:19:58 -0500
On Mon, 2005-01-10 at 09:54 +0100, Andrea Campi wrote:
> On Mon, Jan 10, 2005 at 03:48:59AM -0500, Joe Marcus Clarke wrote:
> > > > 
> > > >   Modified files:
> > > >     devel/gnomevfs2      Makefile 
> > > >   Log:
> > > >   Disable howl support on Alpha during package building since howl is currently
> > > >   broken on Alpha.  I'm waiting to hear back from the maintainer on a proposed
> > > >   fix.
> > > 
> > > I also posted a proposed fix on this list a couple of days ago. If (either
> > > one) can be verified to be working, I'll see that it is committed to the
> > > upstream vendor.
> > 
> > You include stdint.h unconditionally which isn't present on 4.X.  I was
> > thinking of using inttypes.h instead.
> 
> Sure, that's better. Did you actually test it builds on both i386 and alpha?

I don't have an Alpha, and I don't have access to one running 4.X (only
4.X is affected).

> 
> Keep in mind however that this is a stopgap measure anyway. I don't like the
> header pollution, and when submitting this to the vendor I'll try to have all
> source files that include this header include any prerequisite (given that it's
> OS dependent anyway). This might be complicated by the fact that this header
> file comes from Apple, so the fix might need to wait on them also.
> 
> All this to say that an ok fix would be fine, no need to have a perfect one ;-)

I believe the problem is that _LP64 is not defined on 4.X Alpha.  This
should build just fine on 5.X and higher.  I think a better fix might be
to add -D_LP64 to CPPFLAGS for Alpha, but I have no way to test that.

In any event, I think I'll keep gnomevfs2 without howl support on Alpha
for now, try to get the 4.11 tag slipped, then include the _LP64 hack in
the howl 0.9.8 update, and get the maintainer's take on it.

Joe

> 
> 
> Bye,
> 	Andrea
> 
> 
-- 
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome_at_FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome

Received on Mon Jan 10 2005 - 09:20:03 UTC