Re: cvs commit: src/sys/kern vfs_subr.c

From: Pawel Jakub Dawidek <pjd_at_FreeBSD.org>
Date: Fri, 30 Dec 2005 00:06:05 +0100
On Thu, Dec 29, 2005 at 10:52:09PM +0000, Pawel Jakub Dawidek wrote:
+> pjd         2005-12-29 22:52:09 UTC
+> 
+>   FreeBSD src repository
+> 
+>   Modified files:
+>     sys/kern             vfs_subr.c 
+>   Log:
+>   Print a warning when we miss vinactive() call, because of race in vget().
+>   The race is very real, but conditions needed for triggering it are rather
+>   hard to meet now.
+>   When gjournal will be committed (where it is quite easy to trigger) we need
+>   to fix it.
+>   
+>   For now, verify if it is really hard to trigger.
+>   
+>   Discussed with: kan
[...]
+> +		if (usecount > 0 && vp->v_usecount == 0)
+> +			printf("vinactive() won't be called for vp=%p\n", vp);

Hmm, maybe it should be:

	if (usecount > 0 && vp->v_usecount == 0 && oweinact)

?

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd_at_FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

Received on Thu Dec 29 2005 - 23:06:32 UTC