Re: cvs commit: src Makefile.inc1

From: Ruslan Ermilov <ru_at_FreeBSD.ORG>
Date: Thu, 1 Dec 2005 19:27:57 +0200
On Thu, Dec 01, 2005 at 05:08:56PM +0000, Warner Losh wrote:
> imp         2005-12-01 17:08:56 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     .                    Makefile.inc1 
>   Log:
>   In make buildenv, spell sh as ${SHELL}.  In this case, we don't want
>   to hard code /bin/sh since we're forking it for the user to type
>   commands into.  As such, ${SHELL} is the preferred thing users type
>   commands into.
>   
>   Revision  Changes    Path
>   1.524     +1 -1      src/Makefile.inc1
> 
Please consider backing it out.  In this case, we want to hard code it
to "sh" since the stock ~root/.cshrc always resets $PATH, which breaks
"make buildenv" for root (which most of us use).  Testcase: "which cc"
from under "make buildenv" shell.


Cheers,
-- 
Ruslan Ermilov
ru_at_FreeBSD.org
FreeBSD committer

Received on Thu Dec 01 2005 - 17:30:59 UTC