Re: cvs commit: ports/emulators/linux_base-8 Makefile

From: Trevor Johnson <trevor_at_jpj.net>
Date: Fri, 31 Dec 2004 15:11:09 -0500 (EST)
David O'Brien wrote:

> On Thu, Dec 30, 2004 at 07:41:02PM +0000, Trevor Johnson wrote:
> > trevor      2004-12-30 19:41:02 UTC
> >
> >   FreeBSD ports repository
> >
> >   Modified files:
> >     emulators/linux_base-8 Makefile
> >   Log:
> >   On amd64, the installation script contained in the glibc RPM fails.
> >   Work around this by using the --noscripts option.
> >
> >   PR:             75645
> >   Submitted by:   Carlos F. A. Paniago and Conrad J. Sabatier
> >
> >   Revision  Changes    Path
> >   1.94      +1 -0      ports/emulators/linux_base-8/Makefile
> > http://cvsweb.freebsd.org/ports/emulators/linux_base-8/Makefile.diff?r1=1.93&r2=1.94
>
> Please back this out -- it is wrong as you didn't add code to manually do
> all the things glibc's script does.  There is a reason I have't made this
> change -- it gives the perception that this port now cleanly installs and
> runs on AMD64 -- it doesn't (even with this change).  I've put a lot of
> time into trying to polish the linux32 compat experience on FreeBSD/AMD64
> and this undoes some of that effort.

When I made the port, I marked it with "ONLY_FOR_ARCHS=i386".  Without
discussing it with me, you added amd64 to that with the log message "First
cut at supporting AMD64 (to give 32-bit support)" and without adding any
kind of warning that it was broken.  I don't have access to an x86-64
computer but I got the impression from your commit that it was supposed to
work.  Then the next day Mr. Paniagua pointed out that in fact it didn't.
Without ever having heard from you on the subject of the AMD support, I
decided that a kludge would be preferable to something that did not work
at all.
-- 
Trevor Johnson
Received on Fri Dec 31 2004 - 20:11:06 UTC