Re: cvs commit: src Makefile

From: Ruslan Ermilov <ru_at_FreeBSD.org>
Date: Fri, 17 Dec 2004 14:52:00 +0200
Hi Nik,

On Fri, Dec 17, 2004 at 11:20:54AM +0000, Nik Clayton wrote:
> On Thu, Dec 16, 2004 at 07:55:57PM +0000, Ruslan Ermilov wrote:
> >   Previous revision didn't fix all cases.  For example,
> >   testing for variables that are always defined (e.g.,
> >   "make -V CC") would still print a false warning.  Fix
> >   this by only passing a submake the MAKEOBJDIRPREFIX=*
> >   argument if it was present.  As a result, we loose
> >   the check for -DMAKEOBJDIRPREFIX, or an esoteric
> >   "MAKEOBJDIRPREFIX = foo" (with embedded spaces), but
> >   these are unorthodox enough to not care about them.
> >   
> >   The make(1) bug mentioned in the previous revision
> >   was just fixed in make/main.c,v 1.109.
> 
> Do you have test cases for these issues?  They should be added to 
> tools/regression/usr.bin/make.
> 
I know about tools/regression/usr.bin/make (as could be seen
from my commits there).  Unfortunately, the testcase for this
bug is somewhat hard to exploit.  On my i386 testbox, I could
only reproduce it under certain conditions, like the current
working directory, etc.  On amd64, it was always easier (I
don't know why).  The testcase may be as simple as this:

$ env MAKEFLAGS="-f /dev/null" make -V /nonexistent
make: cannot open /nonexistent.
$ echo $?
2

The bug is that the value of "/nonexistent" will replace the
value of "/dev/null".


Cheers,
-- 
Ruslan Ermilov
ru_at_FreeBSD.org
FreeBSD committer

Received on Fri Dec 17 2004 - 12:52:35 UTC