Re: cvs commit: src/sys/dev/ata ata-dma.c ata-pci.c

From: Dan Strick <strick_at_covad.net>
Date: Fri, 24 Oct 2003 08:12:34 -0700 (PDT)
On Wed, 22 Oct 2003 Soren Schmidt wrote:
>
> If we are talking about the same thing, current does NOT need that patch
> and its also bad on releng4, it clears the error bits which are read
> later on for errors...

If we are talking about the code in ata_pci_intr() in ata-pci.c that
clears the ATA_BMSTAT_INTERRUPT bit in the bus master control block
status register and some other bits including the ATA_BMSTAT_ERROR bit, 
my recommended patch cleared only the interrupt bit but it was changed
to be consistent with similar existing code used for other chipsets.

John Baldwin wanted to run my version by Soren before using it instead
of the similar existing code.

Dan Strick
strick_at_covad.net
Received on Fri Oct 24 2003 - 08:12:56 UTC