Re: cvs commit: src/contrib/gdtoa gdtoaimp.h

From: David Schultz <das_at_FreeBSD.org>
Date: Wed, 26 Mar 2003 19:56:44 -0800
Thus spake Andrey A. Chernov <ache_at_nagual.pp.ru>:
> On Wed, Mar 19, 2003 at 21:45:02 -0800, David Schultz wrote:
> > Do
> > you see anything else I should bug the vendor about while I'm at
> > it?  
> 
> With nowdays variant there is error in gethex.c:
> 
> CONST unsigned char *decpt, *s0, *s, *s1;
> ...
> char decimalpoint = *localeconv()->decimal_point;
> ...
> if (*s == decimalpoint) {
>        ^^^ It fails, if decimal point is in upper half of code table, i.e.
>        negative char.
>        
> Obvious fix:
> unsigned char decimalpoint ...

I wasn't aware that there existed locales that used anything other
than a decimal point or comma.  In any case, I've let the vendor know.
Received on Wed Mar 26 2003 - 19:56:48 UTC