Re: cvs commit: src/contrib/gdtoa gdtoaimp.h

From: Andrey A. Chernov <ache_at_nagual.pp.ru>
Date: Wed, 26 Mar 2003 18:14:11 +0300
On Wed, Mar 19, 2003 at 21:45:02 -0800, David Schultz wrote:
> Do
> you see anything else I should bug the vendor about while I'm at
> it?  

With nowdays variant there is error in gethex.c:

CONST unsigned char *decpt, *s0, *s, *s1;
...
char decimalpoint = *localeconv()->decimal_point;
...
if (*s == decimalpoint) {
       ^^^ It fails, if decimal point is in upper half of code table, i.e.
       negative char.
       
Obvious fix:
unsigned char decimalpoint ...

-- 
Andrey A. Chernov
http://ache.pp.ru/
Received on Wed Mar 26 2003 - 07:14:14 UTC