Re: cvs commit: src/sys/net if.c
Sam Leffler <sam_at_errno.com> wrote:
> On Friday 26 December 2003 10:09 am, Brian Feldman wrote:
> > green 2003/12/26 10:09:35 PST
> > FreeBSD src repository
> > Modified files:
> > sys/net if.c
> > Log:
> > Don't truncate the interface name in ifunit(). It's now possible to
> > query "very long interface names", e.g.:
> > ndis_atheros0: flags=8847<UP,BROADCAST,DEBUG,RUNNING,SIMPLEX,MULTICAST>
> > mtu 1500
> I'm not sure this works out well as I believe user-level apps like netstat
> assume interface names are short max-lengthed strings. I've been using the
> ndis stuff (great work btw) and was thinking instead that it would be nice to
> customize the device by specifying the name at config time.
> I think you need to discuss changes like this before committing them.
They are still short max-length strings. ifunit() wasn't accounting for the
"dev/" it was appending when it searches for a given interface, so it was
limiting things to IFNAMSIZE - 4 accidentally.
Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\
<> green_at_FreeBSD.org \ The Power to Serve! \
Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Received on Fri Dec 26 2003 - 10:26:47 UTC