Re: cvs commit: src/sys/boot/powerpc/loader conf.c

From: Peter Grehan <grehan_at_freebsd.org>
Date: Fri, 12 Dec 2003 16:52:55 +1000
> These changes seem to be basically correct and have correct style
> except for not merging the declarations of most of the new "int ch"
> variables with the declarations of the other int variables.

  OK, I'll sweep through and fix that.

> The fix for kg_nice in proc.h is missing.  Only the relatively unimportant
> declaration of ki_nice in user.h is fixed.

  Yep, mis-edited that one out of the diff :-(.

> What bugs does putting negative niceness in the (unsigned) char variable
> kg_nice cause?

  Comparisons to NZERO don't work as expected e.g.

/usr/home/grehan/freebsd/dev/src/bin/ps/print.c: In function `state':
/usr/home/grehan/freebsd/dev/src/bin/ps/print.c:250: warning: comparison 
is always false due to limited range of data type

later,

Peter.
Received on Thu Dec 11 2003 - 22:52:26 UTC