From nobody Sat Sep 20 11:02:17 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cTRKb5by3z68fSG for ; Sat, 20 Sep 2025 11:02:27 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from vogon.madpilot.net (vogon.madpilot.net [159.69.1.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cTRKb2wmxz49gl for ; Sat, 20 Sep 2025 11:02:27 +0000 (UTC) (envelope-from mad@madpilot.net) Authentication-Results: mx1.freebsd.org; none Received: from localhost (mail [IPv6:fd5c:5351:d272::3]) by vogon.madpilot.net (Postfix) with ESMTP id 4cTRKS2BQGzLl42; Sat, 20 Sep 2025 13:02:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject:date:date :message-id:received; s=cyq4qetkgngm; t=1758366137; x= 1760180538; bh=uvdlF8AKEmk0vcnsopOJSXf7Ww/igzEQQ0XHqMnI7ds=; b=j iBPO+w42FnpTSikmFqJ1ykZOvgOZqxxVezo65GVc7vp7yNnr98U5CSMLvvlXEZmy Mz4doBsFVb0ktO3Fc+x+1IXWxHr1oNAN9yW++qMjrL2IkF9w+htcXS2MFZmREMOO qYJWBwsl2I0ve9fBLTteJaw9cmQFrEkp5uC8YJ/ozYKR022q96FU+PLO+M+bZgU7 aGMwQVqUYWAq0RbHy+snToOkyPSLivknfrx4eofD55sJm/uCNt1prCr+gxoyg0HW bVN73wn+HPAqrz/UwBqtQkoDe6fLxiqhNhFVmUpiKuMug3xAkxzEBr2U5QKdws3W b1AZGwEjRemjaXmYI6m8w== Received: from vogon.madpilot.net ([IPv6:fd5c:5351:d272::3]) by localhost (vogon.madpilot.net [IPv6:fd5c:5351:d272::3]) (amavis, port 10026) with ESMTP id 0qCWXPqhOoDN; Sat, 20 Sep 2025 13:02:17 +0200 (CEST) Message-ID: Date: Sat, 20 Sep 2025 13:02:17 +0200 Subject: Re: Possible incompatible change with initgroups(3)? To: Cy Schubert , freebsd-current@freebsd.org, Darrin Smith References: <20250920.080248.183796883139076827.yasu@FreeBSD.org> <20250920084357.32586ee5@darrin.worldsmith.org> <4215EA85-106C-42E4-B6B1-39507CF06729@cschubert.com> Content-Language: en-US, it, en-GB From: Guido Falsi Autocrypt: addr=mad@madpilot.net; keydata= xsBNBE+G+l0BCADi/WBQ0aRJfnE7LBPsM0G3m/m3Yx7OPu4iYFvS84xawmRHtCNjWIntsxuX fptkmEo3Rsw816WUrek8dxoUAYdHd+EcpBcnnDzfDH5LW/TZ4gbrFezrHPdRp7wdxi23GN80 qPwHEwXuF0X4Wy5V0OO8B6VT/nA0ADYnBDhXS52HGIJ/GCUjgqJn+phDTdCFLvrSFdmgx4Wl c0W5Z1p5cmDF9l8L/hc959AeyNf7I9dXnjekGM9gVv7UDUYzCifR3U8T0fnfdMmS8NeI9NC+ wuREpRO4lKOkTnj9TtQJRiptlhcHQiAlG1cFqs7EQo57Tqq6cxD1FycZJLuC32bGbgalABEB AAHNHkd1aWRvIEZhbHNpIDxtYWRAbWFkcGlsb3QubmV0PsLAeQQTAQgAIwIbAwIeAQIXgAUL CQgHAwUVCgkICwQWAgMBBQJS79AgAhkBAAoJEBrmhg5Wy9KTc0kH/RO64ORBlTbTHaUaOj8F Je5O5NU2Pt9Cyt5ZWBRvxntr1zPTJGKRPS9ihlIfqT4ZvEngQGp57EUyFbCpI0UWasTerImM tt5WACnGmCzUTB39UXx8Oy4b1EgWeTJQ747e/F1mQLXTNa6ijRBE9fYlTb4gAkPN88/wVV9v 3PZozKLTg16ghBzHM/P7Lk8L7clPEZChX1FTa/6eSt3nvzfCuTMZbBPJF/ph+q1KyPqRgVfh tyhu5dvgMoPz/ni41IfeSrkJTD5RXzdyGR9q4Z1NYeBsLkRjC4LxKAP5KqUsvlOUjKvO1byj ApYdMarol+IGkaSk9e3zVYAJkWKjn/ni8XbOwU0EUxB7QQEQAKFhrDceoPdK/IHDSmoj6SQY isvM7VdhcleS7E9DoEAVt7yMbf6HbbMVTTY6ckvwTWQssywLBXNVqxgc4WLJjzfUhgef+WE7 5M3+WFYlOVQLGZY/zEVgma1raYnOHNAOzeHLDmEXjbZP6vGAeDyBbGfQPpE7qGYZ7ubeT3Xw QO+PklcCrvOPj2ZPcAxGNS2xVU/LzONqCrJqLMJSIcCdsbiSP4G5PnDFHtMokaTY6OEr8OEQ fOAerhcHUa/z7Uu8YtmaqKH+QGkE/WEgaRqSiTnv0JOTD+DxehaqvoKPPZ++2NpCZMHB2i6A /xifmQwEiIjEXtcueBRzkNUQkxhqZyS13SrhocL9ydtaVPBzZatAEjUDDEJmAMLVFs45qfyh MiNapHJo2n3MW/E5omqCvEkDdWX/en3P7CK2TemeaDghMsgkNKax/z0wNo5UZCkOPOz0xpNi UilOVbkuezZZNg65741qee2lfXhQIaZ66yT7hphc/N/z3PIAtLeze4u1VR2EXAuZ2sWAdlKC NTlJMsaU/x70BV11Wd/ypnVzM68dfdQIIAj1iMFAD/lXGlEUmKXg5Ov2VQDlTntQoanCYrAg +8CttPzjrydgLZFq3hrtQmfc0se5yv1WHS69+BsUOG09RvvawUDZxUjW19kyeN9THaNRgow3 kSuArUp6zSmJABEBAAHCwF8EGAEIAAkFAlMQe0ECGwwACgkQGuaGDlbL0pMN5wgA4bCkX/qw EVC06ToeR6C2putmSWQMgpDaqrv65Hubo+QGmg2P4ewTYQQ4g6oYWS03qHxqVVWhKz7FjfrV +dH8qbCLfSgIcvdBha7ayGZVrsiuMLKGbw36fcmkZPpSDOfHcP0XH8Z+u9CWj0xUkTxAlZ/7 i6gYSUpG2JWNtdmE/X8VVEyXusCLwy0K0BI60A/4dRTIX3C4QKrJ3ZbUXegz70ynjHf+lQMZ 9IZKASoRMuS5FozPQh6abvmwZEPdf5I9riUElzvHrqJ8Bx0t3Pujdoth+yNHpnBxrtO8LkQd rQ58P0SwcaIX33T2U9pG8bhu5YVR88FQ8OQ0cEsPBpDncg== In-Reply-To: <4215EA85-106C-42E4-B6B1-39507CF06729@cschubert.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:159.69.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cTRKb2wmxz49gl List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org On 9/20/25 12:34, Cy Schubert wrote: > On September 19, 2025 4:13:57 p.m. PDT, Darrin Smith wrote: >> On Sat, 20 Sep 2025 08:02:48 +0900 (JST) >> Yasuhiro Kimura wrote: >> >>> Today I updated my 16.0-CURRENT amd64 system from >>> main-n280279-b0e7b55a0e90 to main-n280498-b3468202994f and noticed >>> Postfix emits such error messages as below. >>> >>> ---------------------------------------------------------------------- >>> Sep 20 03:00:11 rolling-vm-freebsd1 postfix/qmgr[2634]: fatal: >>> initgroups: Socket operation on non-socket Sep 20 03:00:11 >>> rolling-vm-freebsd1 postfix/pickup[2635]: fatal: initgroups: Socket >>> operation on non-socket Sep 20 03:01:00 rolling-vm-freebsd1 >>> postfix/showq[66274]: fatal: initgroups: Socket operation on >>> non-socket >>> ---------------------------------------------------------------------- >>> >>> So I rebuilt, reinstalled and restared Postfix. Then error message >>> disappeared. >>> >>> I checked commit log between b0e7b55a0e90 and b3468202994f, and found >>> following one. >>> >>> ---------------------------------------------------------------------- >>> commit 0b018cfd81d8 >>> Author: Olivier Certner >>> AuthorDate: Tue Sep 16 17:52:20 2025 +0200 >>> Commit: Olivier Certner >>> CommitDate: Wed Sep 17 14:16:06 2025 +0200 >>> >>> initgroups(3): Fix return value on allocation failure >>> >>> We must not return ENOMEM, but rather -1 with 'errno' set to >>> ENOMEM, as described in the manual page and as other implementations >>> are doing. A malloc() failure actually already sets ENOMEM for us. >>> Add comments indicating which function set 'errno' each time we >>> return. >>> While here, improve style and remove useless headers. >>> >>> Reviewed by: kib, emaste >>> Fixes: 54404cfb13d4 ("In preparation for raising NGROUPS >>> and NGROUPS_MAX, ...") MFC after: 5 days >>> Sponsored by: The FreeBSD Foundation >>> Differential Revision: https://reviews.freebsd.org/D52580 >>> ---------------------------------------------------------------------- >>> >>> According to commit message, it is likely that the commit introduces >>> some incompatibility with initgroups(3) and that it causes error >>> messages of Postfix. And if it is correct, then __FreeBSD_version >>> should be bumped to force packages that use initgroups(3) to be >>> rebuilt. >>> >>> --- >>> Yasuhiro Kimura >>> >> >> I can confirm this issue. I've had to recompile audio/musicpd >> and sysutils/bareos23-client to resolve it. (Also getting >> the same Socket operation on non-socket in each case). >> > > I can confirm as well with postfix, the krb5 port, nut, openldap26-server, dovecot, and others that I cannot recall ATM. > > Just for the record, lightdm is also affected by this very issue with the same symptoms. -- Guido Falsi